From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org, rth@twiddle.net,
"Aurelien Jarno" <aurelien@aurel32.net>,
borntraeger@de.ibm.com,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files
Date: Mon, 21 Aug 2017 11:52:58 +0200 [thread overview]
Message-ID: <20170821115258.4f94ff12.cohuck@redhat.com> (raw)
In-Reply-To: <2b685ad1-fc58-e68d-51ee-32128b5b1555@redhat.com>
On Fri, 18 Aug 2017 19:28:34 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 18.08.2017 18:08, Thomas Huth wrote:
> > On 18.08.2017 13:43, David Hildenbrand wrote:
> >> s390-stattrib.c needs definition of TARGET_PAGE_SIZE, solve it via cpu.h.
> >
> > Why not simply #include "exec/cpu-all.h" ? If cpu.h is not really needed
> > here...
> >
> > Thomas
> >
> >
>
> Git grep showed me that this is a very rare thing to do, so I went for
> cpu.h. If you prefer cpu-all.h, I can use that.
Is there any target that does not include cpu-all.h in its cpu.h? We
probably can remove all includes of cpu-all.h in .c files, as all of
them include cpu.h as well...
next prev parent reply other threads:[~2017-08-21 9:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 11:43 [Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 01/18] s390x/kvm: drop KVMState parameter from s390_get_memslot_count() David Hildenbrand
2017-08-18 15:36 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 02/18] s390x/kvm: drop KVMState parameter from kvm_s390_set_mem_limit() David Hildenbrand
2017-08-18 15:39 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed() David Hildenbrand
2017-08-18 15:52 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed() David Hildenbrand
2017-08-18 15:59 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 05/18] target/s390x: no need to pass kvm_state to savevm_gtod handlers David Hildenbrand
2017-08-18 15:41 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 06/18] s390x/cpumodel: factor out determination of default model name David Hildenbrand
2017-08-18 16:04 ` Thomas Huth
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files David Hildenbrand
2017-08-18 16:08 ` Thomas Huth
2017-08-18 17:28 ` David Hildenbrand
2017-08-21 9:52 ` Cornelia Huck [this message]
2017-08-21 10:50 ` David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h David Hildenbrand
2017-08-18 16:11 ` Thomas Huth
2017-08-18 17:28 ` David Hildenbrand
2017-08-24 12:08 ` Cornelia Huck
2017-08-21 10:08 ` Cornelia Huck
2017-08-21 11:05 ` David Hildenbrand
2017-08-21 11:14 ` Cornelia Huck
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 09/18] target/s390x: move cc_name() to helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 10/18] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 11/18] target/s390x: move psw_key_valid() to mem_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 12/18] target/s390x: move s390_do_cpu_reset() to diag.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 13/18] target/s390x: move get_per_in_range() to misc_helper.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 14/18] target/s390x: introduce internal.h David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 15/18] target/s390x: move a couple of functions to cpu.c David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 16/18] s390x: avoid calling kvm_ functions outside of target/s390x/ David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 17/18] s390x/kvm: move KVM declarations and stubs to separate files David Hildenbrand
2017-08-18 11:43 ` [Qemu-devel] [PATCH v3 for-2.11 18/18] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-18 11:45 ` [Qemu-devel] [PATCH v3 for-2.11 00/18] " David Hildenbrand
2017-08-24 12:30 ` Cornelia Huck
2017-08-25 9:26 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821115258.4f94ff12.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).