From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, thuth@redhat.com,
zyimin@linux.vnet.ibm.com, david@redhat.com,
pmorel@linux.vnet.ibm.com, agraf@suse.de, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions
Date: Mon, 21 Aug 2017 15:16:50 +0200 [thread overview]
Message-ID: <20170821151650.35050b3e.cohuck@redhat.com> (raw)
In-Reply-To: <700d1722-baf1-163e-6764-179f1340cc22@linux.vnet.ibm.com>
On Mon, 21 Aug 2017 13:41:53 +0200
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> On 08/21/2017 11:16 AM, Cornelia Huck wrote:
> > If we do not provide zpci, pci reconfiguration via sclp is not available
> > either. Don't indicate it in the sclp facilities and return an invalid
> > command if the guest tries to issue pci configure/deconfigure.
> >
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> > hw/s390x/sclp.c | 19 +++++++++++++++----
> > 1 file changed, 15 insertions(+), 4 deletions(-)
(...)
> LGTM
Is that an Acked-by:? Or a Reviewed-by:? :)
next prev parent reply other threads:[~2017-08-21 13:17 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 9:16 [Qemu-devel] [PATCH v4 00/10] zpci detangling Cornelia Huck
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 01/10] 9pfs: fix dependencies Cornelia Huck
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 02/10] kvm: remove hard dependency on pci Cornelia Huck
2017-08-21 16:02 ` Pierre Morel
2017-08-22 9:04 ` Cornelia Huck
2017-08-23 11:05 ` Pierre Morel
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 03/10] s390x/pci: add stubs Cornelia Huck
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 04/10] s390x: chsc nt2 events are pci-only Cornelia Huck
2017-08-21 12:24 ` Thomas Huth
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 05/10] s390x/pci: do not advertise pci on non-pci builds Cornelia Huck
2017-08-21 12:29 ` Thomas Huth
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 06/10] s390x/ccw: create s390 phb conditionally Cornelia Huck
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions Cornelia Huck
2017-08-21 11:41 ` Halil Pasic
2017-08-21 13:16 ` Cornelia Huck [this message]
2017-08-21 13:32 ` Halil Pasic
2017-08-21 13:36 ` Cornelia Huck
2017-08-21 14:58 ` Pierre Morel
2017-08-21 16:24 ` Halil Pasic
2017-08-22 8:39 ` Cornelia Huck
2017-08-22 9:20 ` Halil Pasic
2017-08-22 9:39 ` Cornelia Huck
2017-08-22 12:57 ` Cornelia Huck
2017-08-22 13:00 ` Halil Pasic
2017-08-22 12:58 ` Halil Pasic
2017-08-22 13:24 ` Cornelia Huck
2017-08-22 13:54 ` Halil Pasic
2017-08-22 14:15 ` Cornelia Huck
2017-08-22 14:34 ` Halil Pasic
2017-08-22 15:10 ` Cornelia Huck
2017-08-22 14:06 ` Cornelia Huck
2017-08-22 14:27 ` Halil Pasic
2017-08-22 14:34 ` Cornelia Huck
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 08/10] s390x/pci: fence off instructions for non-pci Cornelia Huck
2017-08-23 14:10 ` Halil Pasic
2017-08-23 15:40 ` Cornelia Huck
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup " Cornelia Huck
2017-08-21 12:00 ` Halil Pasic
2017-08-21 12:13 ` Cornelia Huck
2017-08-21 15:10 ` Halil Pasic
2017-08-21 15:17 ` Thomas Huth
2017-08-21 15:30 ` Halil Pasic
2017-08-23 10:03 ` Cornelia Huck
2017-08-21 9:16 ` [Qemu-devel] [PATCH v4 10/10] s390x: refine pci dependencies Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821151650.35050b3e.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=zyimin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).