qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Manos Pitsidianakis <el13635@mail.ntua.gr>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: qemu-block <qemu-block@nongnu.org>,
	Alberto Garcia <berto@igalia.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH v7 0/6] add throttle block driver filter
Date: Tue, 22 Aug 2017 13:15:29 +0300	[thread overview]
Message-ID: <20170822101535.4695-1-el13635@mail.ntua.gr> (raw)

This series adds a throttle block driver filter. Currently throttling is done
at the BlockBackend level. Using block driver interfaces we can move the
throttling to any point in the BDS graph using a throttle node which uses the
existing throttling code. This allows for potentially more complex
configurations (throttling at any point in the graph, chained filters)

v7:
  remove anonymous groups
  error on missing throttle-group option on block/throttle.c
  change switch case format in block/throttle-groups.c (berto)

v6:
  don't allow named group limit configuration in block/throttle.c; allow either
        -drive driver=throttle,file.filename=foo.qcow2, \
            limits.iops-total=...
      or
        -drive driver=throttle,file.filename=foo.qcow2,throttle-group=bar
  fixes suggested by berto

v5:
  fix crash in 'add aio_context field in ThrottleGroupMember'
  fix suggestions in block/throttle.c

v4:
  fix suggestions in block/throttle.c
  fix suggestions in block/throttle_groups.c
  add doc note in BlockDevOptionsThrottle

v3:
  fix style error in 'add aio_context field in ThrottleGroupMember'

v2:
  change QOM throttle group object name
  print valid ranges for uint on error
  move frees in throttle_group_obj_finalize()
  split throttle_group_{set,get}()
  add throttle_recurse_is_first_non_filter()

Manos Pitsidianakis (6):
  block: move ThrottleGroup membership to ThrottleGroupMember
  block: add aio_context field in ThrottleGroupMember
  block: tidy ThrottleGroupMember initializations
  block: convert ThrottleGroup to object with QOM
  block: add throttle block filter driver
  qemu-iotests: add 184 for throttle filter driver

 qapi/block-core.json            |  66 +++-
 include/block/throttle-groups.h |  48 ++-
 include/qemu/throttle-options.h |  60 ++--
 include/qemu/throttle.h         |   3 +
 include/sysemu/block-backend.h  |  20 +-
 block/block-backend.c           |  62 ++--
 block/qapi.c                    |   8 +-
 block/throttle-groups.c         | 737 +++++++++++++++++++++++++++++-----------
 block/throttle.c                | 250 ++++++++++++++
 blockdev.c                      |   4 +-
 tests/test-throttle.c           | 111 +++---
 util/throttle.c                 | 151 ++++++++
 block/Makefile.objs             |   1 +
 tests/qemu-iotests/184          | 205 +++++++++++
 tests/qemu-iotests/184.out      | 300 ++++++++++++++++
 tests/qemu-iotests/group        |   1 +
 16 files changed, 1706 insertions(+), 321 deletions(-)
 create mode 100644 block/throttle.c
 create mode 100755 tests/qemu-iotests/184
 create mode 100644 tests/qemu-iotests/184.out

-- 
2.11.0

             reply	other threads:[~2017-08-22 10:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 10:15 Manos Pitsidianakis [this message]
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 1/6] block: move ThrottleGroup membership to ThrottleGroupMember Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 2/6] block: add aio_context field in ThrottleGroupMember Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 3/6] block: tidy ThrottleGroupMember initializations Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 4/6] block: convert ThrottleGroup to object with QOM Manos Pitsidianakis
2017-08-22 13:25   ` Alberto Garcia
2017-08-22 13:31     ` Manos Pitsidianakis
2017-08-24 18:31   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 5/6] block: add throttle block filter driver Manos Pitsidianakis
2017-08-22 14:16   ` Alberto Garcia
2017-08-22 14:22     ` Manos Pitsidianakis
2017-08-24 18:39   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle " Manos Pitsidianakis
2017-08-23  8:57   ` Alberto Garcia
2017-08-24 18:43   ` Stefan Hajnoczi
2017-08-24 21:15     ` Manos Pitsidianakis
2017-08-25 11:05       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170822101535.4695-1-el13635@mail.ntua.gr \
    --to=el13635@mail.ntua.gr \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).