From: Cornelia Huck <cohuck@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator
Date: Tue, 22 Aug 2017 13:48:15 +0200 [thread overview]
Message-ID: <20170822134815.77020eb8.cohuck@redhat.com> (raw)
In-Reply-To: <20170822112046.GC12356@umbus.fritz.box>
On Tue, 22 Aug 2017 21:20:46 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> Obviously it's not a thing to fix right now, but I've really been
> thinking that none of the tests should use this "TCG or KVM" stuff.
> They should instead be run with *both* options - or at least the ones
> that are available on the host.
Having one test as a 'smoke test' that is run for everything available
sounds like a good idea, and the boot-serial test may be a good
candidate for that.
I would not want to run every test with every accelerator, however, as
this makes 'make check' even slower than it is now. (Although it may be
useful to be able to trigger 'run everything' tests on some dedicated
test machines.)
>
> That would have caught the bug in the pull request I sent you, and
> would at least have given you a chance at seeing the problem with
> boot-serial-test.
I don't think that would have been caught unless you have the right
host available... and given that most developers will only have a
x86_64 machine and whatever other architecture they are working on (if
any) available, they will run most of 'make check' with tcg only.
next prev parent reply other threads:[~2017-08-22 11:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 8:26 [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator Cornelia Huck
2017-08-16 8:28 ` Laurent Vivier
2017-08-16 10:25 ` Thomas Huth
2017-08-16 10:51 ` Paolo Bonzini
2017-08-16 11:18 ` Peter Maydell
2017-08-16 11:46 ` Cornelia Huck
2017-08-22 1:09 ` David Gibson
2017-08-22 5:40 ` Thomas Huth
2017-08-22 8:47 ` Peter Maydell
2017-08-22 8:49 ` Laurent Vivier
2017-08-22 9:35 ` Peter Maydell
2017-08-22 11:20 ` David Gibson
2017-08-22 11:48 ` Cornelia Huck [this message]
2017-08-23 0:29 ` David Gibson
2017-08-23 7:16 ` Cornelia Huck
2017-08-23 7:49 ` [Qemu-devel] make check speed (was: Re: [PATCH for-2.10] boot-serial-test: prefer tcg accelerator) Thomas Huth
2017-08-23 8:01 ` [Qemu-devel] make check speed Paolo Bonzini
2017-08-23 8:35 ` Thomas Huth
2017-08-23 8:52 ` Fam Zheng
2017-08-23 9:09 ` Fam Zheng
2017-08-23 9:33 ` Paolo Bonzini
2017-08-24 3:01 ` David Gibson
2017-08-23 11:51 ` Lukáš Doktor
2017-08-23 12:01 ` Thomas Huth
2017-08-23 12:13 ` Lukáš Doktor
2017-08-24 13:52 ` Cleber Rosa
2017-08-23 12:35 ` Thomas Huth
2017-08-23 12:52 ` Lukáš Doktor
2017-08-23 12:20 ` Cornelia Huck
2017-08-24 5:27 ` Thomas Huth
2017-08-30 8:59 ` Cornelia Huck
2017-08-30 9:13 ` Thomas Huth
2017-08-30 11:52 ` Markus Armbruster
2017-08-30 13:56 ` Thomas Huth
2017-08-30 14:19 ` Markus Armbruster
2017-08-29 16:34 ` Thomas Huth
2017-08-29 17:13 ` Thomas Huth
2017-08-16 14:03 ` [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822134815.77020eb8.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).