From: Manos Pitsidianakis <el13635@mail.ntua.gr>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-block <qemu-block@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 5/6] block: add throttle block filter driver
Date: Tue, 22 Aug 2017 17:22:46 +0300 [thread overview]
Message-ID: <20170822142246.x2wtondegbcmm7fy@postretch> (raw)
In-Reply-To: <w51tw0zg01x.fsf@maestria.local.igalia.com>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
On Tue, Aug 22, 2017 at 04:16:26PM +0200, Alberto Garcia wrote:
>On Tue 22 Aug 2017 12:15:34 PM CEST, Manos Pitsidianakis wrote:
>> @@ -548,6 +548,11 @@ void throttle_group_unregister_tgm(ThrottleGroupMember *tgm)
>> ThrottleGroupMember *token;
>> int i;
>>
>> + if (!ts) {
>> + /* Discard uninitialized tgm */
>> + return;
>> + }
>> +
>
>Is this change needed in case throttle_configure_tgm() fails?
Yes, now all errors are before throttle_group_register_tgm(), therefore
the unregister part in throttle_close() will not have valid data.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-22 14:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 10:15 [Qemu-devel] [PATCH v7 0/6] add throttle block driver filter Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 1/6] block: move ThrottleGroup membership to ThrottleGroupMember Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 2/6] block: add aio_context field in ThrottleGroupMember Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 3/6] block: tidy ThrottleGroupMember initializations Manos Pitsidianakis
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 4/6] block: convert ThrottleGroup to object with QOM Manos Pitsidianakis
2017-08-22 13:25 ` Alberto Garcia
2017-08-22 13:31 ` Manos Pitsidianakis
2017-08-24 18:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 5/6] block: add throttle block filter driver Manos Pitsidianakis
2017-08-22 14:16 ` Alberto Garcia
2017-08-22 14:22 ` Manos Pitsidianakis [this message]
2017-08-24 18:39 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 10:15 ` [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle " Manos Pitsidianakis
2017-08-23 8:57 ` Alberto Garcia
2017-08-24 18:43 ` Stefan Hajnoczi
2017-08-24 21:15 ` Manos Pitsidianakis
2017-08-25 11:05 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822142246.x2wtondegbcmm7fy@postretch \
--to=el13635@mail.ntua.gr \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).