From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36626)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1dkBNe-00070z-Dg
	for qemu-devel@nongnu.org; Tue, 22 Aug 2017 11:46:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1dkBNd-0005TF-NL
	for qemu-devel@nongnu.org; Tue, 22 Aug 2017 11:46:14 -0400
Date: Tue, 22 Aug 2017 17:45:58 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20170822174558.5db57e9f@nial.brq.redhat.com>
In-Reply-To: <87shgjaezt.fsf@dusky.pond.sub.org>
References: <1502117160-24655-1-git-send-email-armbru@redhat.com>
	<1502117160-24655-13-git-send-email-armbru@redhat.com>
	<20170822145505.643f74fa@nial.brq.redhat.com>
	<87shgjaezt.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 12/56] pc-dimm: Make size and address
 unsigned in QAPI/QMP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, pbonzini@redhat.com, marcandre.lureau@redhat.com, mreitz@redhat.com, jsnow@redhat.com

On Tue, 22 Aug 2017 15:50:14 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Igor Mammedov <imammedo@redhat.com> writes:
> 
> > On Mon,  7 Aug 2017 16:45:16 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >  
> >> Sizes and addresses should use QAPI type 'size' (uint64_t).
> >> PCDIMMDeviceInfo members @addr and @size are 'int' (int64_t).
> >> qmp_pc_dimm_device_list() implicitly converts from uint64_t.
> >> 
> >> Change these PCDIMMDeviceInfo members to 'size'.
> >> 
> >> query-memory-devices now reports sizes and addresses above 2^63-1
> >> correctly instead of their (negative) two's complement.
> >> 
> >> HMP's "info memory-devices" already reported them correctly, because
> >> it printed the signed integers with PRIx64 and PRIu32.  
> > s/signed/unsigned/  
> 
> Before this patch: signed.  Afterwards: unsigned.  Would
> 
>    HMP's "info memory-devices" already reported them correctly, because
>    it printed the signed (before the patch) integers with PRIx64 and
>    PRIu32.
> 
> be clearer?
yes, that's more clear

Thanks.

> 
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>  
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>  
> 
> Thanks!