From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkEHe-0005ur-0G for qemu-devel@nongnu.org; Tue, 22 Aug 2017 14:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkEHa-0000ND-SL for qemu-devel@nongnu.org; Tue, 22 Aug 2017 14:52:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49080) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkEHa-0000Mu-IP for qemu-devel@nongnu.org; Tue, 22 Aug 2017 14:52:10 -0400 Date: Tue, 22 Aug 2017 15:51:58 -0300 From: Eduardo Habkost Message-ID: <20170822185158.GI19998@localhost.localdomain> References: <20170818142613.32394-1-ldoktor@redhat.com> <87bmn8qd3z.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87bmn8qd3z.fsf@dusky.pond.sub.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: John Snow , =?utf-8?B?THVrw6HFoQ==?= Doktor , qemu-devel@nongnu.org, famz@redhat.com, apahim@redhat.com, f4bug@amsat.org, mreitz@redhat.com, "Daniel P. Berrange" , Kevin Wolf , Paolo Bonzini On Tue, Aug 22, 2017 at 09:24:16AM +0200, Markus Armbruster wrote: > John Snow writes: >=20 > > On 08/18/2017 10:26 AM, Luk=C3=A1=C5=A1 Doktor wrote: > >> Hello guys, > >>=20 > >> I'm reading the available python modules to exercise qemu and while = reading them > >> I fixed some issues that caught my attention. It usually starts with= a simple > >> pylint/docstring fixes and slowly graduates to more controversial on= es so I'm > >> open to suggestion to remove some of them. > >>=20 > >> Kind regards, > >> Luk=C3=A1=C5=A1 > >>=20 > >> Changes in v2 > >> - Squashed 2nd and 10th patches into 2nd one > >> - Use repr() in MonitorResponseError's description > >> - Improved commit message of the 6th patch > >> - Two tweaks to docstrings changed in the 6th patch > >> - Also updated qmp-shell to use new-style super calls (7th patch) > >> - Fixed the accidental rename of qmp `cmd_id` (kept the id->cmd_id p= atch) > >> - Changed the style of the style-fix in the 10th commit > >>=20 > >> Changes in v3 > >> - Don't use repr in the 5th patch in MonitorResponseError > >>=20 > >> Changes in v4 > >> - Use correct git base (remove unwanted commits) > >>=20 > >> Changes in v5 > >> - Avoid bool comparison > >> - Change report to return in one docstring > >> - Removed the unnecessary spaces around single-line docstring > >>=20 > >> Changes in v6 > >> - Bunch of docstring tweaks by Markus Armbruster > >> - Line break in <80 chars > >> - result dict =3D> response dict > >> - Removed the "event_match" rename > >>=20 > > > > Looks like all ten patches have an R-B despite changes; but it looks > > like nothing particularly major was changed anyway. > > > > Does this fall under Markus's jurisdiction? > > > > (Well, except for qtest.py which seemingly has double-extra-no > > maintainer...!) >=20 > qemu.py is about starting and controlling QEMU, commonly for testing > purposes. It's related to QMP only by virtue of using QMP for control > (well, what else could it use?); if that makes me maintainer, I'll soon > maintain basically all tests :) >=20 > As far as I can tell, qemu.py's main user is still qemu-iotests, via > qtest.py. Dan factored it out to make it available for > tests/migration/guestperf/. >=20 > Options for maintaining qemu.py and qtest.py: >=20 > * Maintain them with qemu-iotest >=20 > Currently mainained with the block layer core, by Kevin and Max. >=20 > - Keep it that way >=20 > - Appoint qemu-iotest maintainer(s). >=20 > * Maintain them separately, say as "Python qtest support", appoint > maintainer(s) >=20 > Dan appears to be a hot contender: >=20 > $ scripts/get_maintainer.pl -f --git-blame scripts/qtest.py=20 > Fam Zheng (authored lines:71/110=3D65%,commits:1/= 3=3D33%) > "Daniel P. Berrange" (authored lines:39/110=3D= 35%,commits:2/3=3D67%) > Max Reitz (commits:2/3=3D67%) > Amit Shah (commits:1/3=3D33%) > Stefan Hajnoczi (commits:1/3=3D33%) > qemu-devel@nongnu.org (open list:All patches CC here) > $ scripts/get_maintainer.pl -f --git-blame scripts/qemu.py=20 > "Daniel P. Berrange" (authored lines:217/229=3D= 95%,commits:2/4=3D50%) > Eduardo Habkost (authored lines:12/229=3D5%,c= ommits:4/4=3D100%) > Markus Armbruster (commits:1/4=3D25%) > Max Reitz (commits:1/4=3D25%) > Amit Shah (commits:1/4=3D25%) > qemu-devel@nongnu.org (open list:All patches CC here) >=20 > Eduardo made the mistake^W^W^Wgraciously volunteered to maintain > scripts/qmp/qmp-shell, which is also used for testing. Perhaps he'd > be willing to maintain these guys as well. I could take care of queueing patches for the Python modules on the same tree where qmp-shell patches would be queued. However, I would be happier if somebody else agreed to be listed as co-maintainer to at least help on review and decision-making. --=20 Eduardo