Re: [Qemu-devel] [PATCH 14/15] ppc4xx: Add device models found in PPC440 core SoCs

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote:
> These devices are found in newer SoCs based on 440 core e.g. the 460EX
> (http://www.embeddeddeveloper.com/assets/processors/amcc/datasheets/
> PP460EX_DS2063.pdf)

As usual, I can't review in depth, but there's not much obviously
bogus, so I'm inclined to merge, except for one detail:

[snip]
> +#ifdef MAP_L2SRAM
> +static void l2sram_update_mappings(ppc4xx_l2sram_t *l2sram,
> +                                   uint32_t isarc, uint32_t isacntl,
> +                                   uint32_t dsarc, uint32_t dsacntl)
> +{
> +#ifdef DEBUG_L2SRAM
> +    printf("L2SRAM update ISA %08" PRIx32 " %08" PRIx32 " (%08" PRIx32
> +           " %08" PRIx32 ") DSA %08" PRIx32 " %08" PRIx32
> +           " (%08" PRIx32 " %08" PRIx32 ")\n",
> +           isarc, isacntl, dsarc, dsacntl,
> +           l2sram->isarc, l2sram->isacntl, l2sram->dsarc, l2sram->dsacntl);

For new code, trace points are strongly preferred to DPRINTF() macros
or explicit printf()s.  In addition sending this output to stdout
rather than stderr is a pretty bad idea.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]