From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkTgI-0006tb-0c for qemu-devel@nongnu.org; Wed, 23 Aug 2017 07:18:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkTgE-0002Av-2P for qemu-devel@nongnu.org; Wed, 23 Aug 2017 07:18:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkTgD-0002Ac-Rw for qemu-devel@nongnu.org; Wed, 23 Aug 2017 07:18:37 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF2D02027A for ; Wed, 23 Aug 2017 11:18:36 +0000 (UTC) Date: Wed, 23 Aug 2017 19:18:32 +0800 From: Peter Xu Message-ID: <20170823111832.GC19071@pxdev.xzpeter.org> References: <20170823083901.852-1-quintela@redhat.com> <20170823083901.852-2-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170823083901.852-2-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] tests: Use real size for iov tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, lvivier@redhat.com, pbonzini@redhat.com On Wed, Aug 23, 2017 at 10:39:00AM +0200, Juan Quintela wrote: > We were using -1 instead of the real size because the functions check > what is bigger, size in bytes or the size of the iov. Recent gcc's > barf at this. > > Signed-off-by: Juan Quintela > --- > tests/test-iov.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/test-iov.c b/tests/test-iov.c > index a22d71fd2c..819c410a51 100644 > --- a/tests/test-iov.c > +++ b/tests/test-iov.c > @@ -81,17 +81,17 @@ static void test_to_from_buf_1(void) > * skip whole vector and process exactly 0 bytes */ > > /* first set bytes [i..sz) to some "random" value */ > - n = iov_memset(iov, niov, 0, 0xff, -1); > + n = iov_memset(iov, niov, 0, 0xff, sz); This one is not needed? > g_assert(n == sz); > > /* next copy bytes [i..sz) from ibuf to iovec */ > - n = iov_from_buf(iov, niov, i, ibuf + i, -1); > + n = iov_from_buf(iov, niov, i, ibuf + i, sz - i); > g_assert(n == sz - i); > > /* clear part of obuf */ > memset(obuf + i, 0, sz - i); > /* and set this part of obuf to values from iovec */ > - n = iov_to_buf(iov, niov, i, obuf + i, -1); > + n = iov_to_buf(iov, niov, i, obuf + i, sz - i); > g_assert(n == sz - i); > > /* now compare resulting buffers */ > @@ -109,7 +109,7 @@ static void test_to_from_buf_1(void) > * with j in [i..sz]. */ > > /* clear iovec */ > - n = iov_memset(iov, niov, 0, 0xff, -1); > + n = iov_memset(iov, niov, 0, 0xff, sz); This one as well? Actually I think we can keep the two places above, but there seems to be a 3rd one below which is untouched. If we do change the two, maybe we'd better change the 3rd one as well. Besides: Reviewed-by: Peter Xu > g_assert(n == sz); > > /* copy bytes [i..j) from ibuf to iovec */ > -- > 2.13.5 > -- Peter Xu