From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com,
christian.ehrhardt@canonical.com, peterx@redhat.com,
lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: Report when bdrv_inactivate_all fails
Date: Wed, 23 Aug 2017 15:42:17 +0100 [thread overview]
Message-ID: <20170823144217.GD16760@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170822170212.27347-1-dgilbert@redhat.com>
On Tue, Aug 22, 2017 at 06:02:12PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> If the bdrv_inactivate_all fails near the end of the migration,
> the migration will fail and often the only diagnostics in the log
> are an I/O error which you can't distinguish from an error on
> the socket connection.
>
> Add an error so we know when it's actually a block problem.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/savevm.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2017-08-23 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 17:02 [Qemu-devel] [PATCH] migration: Report when bdrv_inactivate_all fails Dr. David Alan Gilbert (git)
2017-08-23 2:13 ` Peter Xu
2017-08-23 14:42 ` Stefan Hajnoczi [this message]
2017-09-06 13:26 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823144217.GD16760@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).