qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: changpeng.liu@intel.com, felipe@nutanix.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH 16/27] vhost-user-scsi: remove VUS_MAX_LUNS
Date: Wed, 23 Aug 2017 18:19:53 +0200	[thread overview]
Message-ID: <20170823162004.27337-17-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20170823162004.27337-1-marcandre.lureau@redhat.com>

There is no code to support more than 1 yet, no need for that today.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 contrib/vhost-user-scsi/vhost-user-scsi.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c
index f6f9e7b192..429e3065ea 100644
--- a/contrib/vhost-user-scsi/vhost-user-scsi.c
+++ b/contrib/vhost-user-scsi/vhost-user-scsi.c
@@ -53,8 +53,6 @@
 
 /** vhost-user-scsi specific definitions **/
 
- /* Only 1 LUN and device supported today */
-#define VUS_MAX_LUNS 1
 #define VUS_ISCSI_INITIATOR "iqn.2016-11.com.nutanix:vhost-user-scsi"
 
 typedef struct iscsi_lun {
@@ -67,7 +65,7 @@ typedef struct vhost_scsi_dev {
     int server_sock;
     GMainLoop *loop;
     GTree *fdmap;   /* fd -> gsource context id */
-    iscsi_lun_t luns[VUS_MAX_LUNS];
+    iscsi_lun_t lun;
 } vhost_scsi_dev_t;
 
 /** glib event loop integration for libvhost-user and misc callbacks **/
@@ -533,7 +531,7 @@ static void vus_proc_req(VuDev *vu_dev, int idx)
         }
         rsp = (VirtIOSCSICmdResp *)elem->in_sg[0].iov_base;
 
-        if (handle_cmd_sync(vdev_scsi->luns[0].iscsi_ctx,
+        if (handle_cmd_sync(vdev_scsi->lun.iscsi_ctx,
                             req, &elem->out_sg[1], elem->out_num - 1,
                             rsp, &elem->in_sg[1], elem->in_num - 1) != 0) {
             vus_panic_cb(vu_dev, NULL);
@@ -722,7 +720,7 @@ int main(int argc, char **argv)
     }
     vdev_scsi = vdev_scsi_new(sock);
 
-    if (iscsi_add_lun(&vdev_scsi->luns[0], iscsi_uri) != 0) {
+    if (iscsi_add_lun(&vdev_scsi->lun, iscsi_uri) != 0) {
         goto err;
     }
 
-- 
2.14.1.146.gd35faa819

  parent reply	other threads:[~2017-08-23 16:21 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 16:19 [Qemu-devel] [PATCH 00/27] vhost-user-scsi: code clean-up Marc-André Lureau
2017-08-23 16:19 ` [Qemu-devel] [PATCH 01/27] glib-compat: move G_SOURCE_CONTINUE/REMOVE there Marc-André Lureau
2017-09-12 12:22   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 02/27] libvhost-user: drop dependency on glib Marc-André Lureau
2017-09-12 12:24   ` Philippe Mathieu-Daudé
2017-09-12 13:13     ` Marc-André Lureau
2017-09-12 13:24       ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 03/27] libvhost-user: improve vu_queue_pop() doc Marc-André Lureau
2017-09-19 13:43   ` Paolo Bonzini
2017-09-19 14:53     ` Eric Blake
2017-09-19 15:01       ` Marc-André Lureau
2017-08-23 16:19 ` [Qemu-devel] [PATCH 04/27] vhost-user-scsi: use g_strdup() Marc-André Lureau
2017-08-23 17:50   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 05/27] vhost-user-scsi: connect unix socket before allocating Marc-André Lureau
2017-09-12 16:37   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 06/27] vhost-user-scsi: code style fixes Marc-André Lureau
2017-08-24  2:54   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 07/27] vhost-user-scsi: use glib allocation Marc-André Lureau
2017-08-23 17:53   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 08/27] vhost-user-scsi: glib calls that allocate don't return NULL Marc-André Lureau
2017-09-19 13:44   ` Paolo Bonzini
2017-08-23 16:19 ` [Qemu-devel] [PATCH 09/27] vhost-user-scsi: also free the gtree Marc-André Lureau
2017-09-12 16:40   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 10/27] vhost-user-scsi: remove vdev_scsi_find_by_vu() Marc-André Lureau
2017-09-19 13:44   ` Paolo Bonzini
2017-08-23 16:19 ` [Qemu-devel] [PATCH 11/27] vhost-user-scsi: simplify unix path cleanup Marc-André Lureau
2017-09-19 13:45   ` Paolo Bonzini
2017-08-23 16:19 ` [Qemu-devel] [PATCH 12/27] vhost-user-scsi: use NULL pointer Marc-André Lureau
2017-08-23 17:47   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 13/27] vhost-user-scsi: use glib watch directly Marc-André Lureau
2017-09-19 13:54   ` Paolo Bonzini
2017-08-23 16:19 ` [Qemu-devel] [PATCH 14/27] vhost-user-scsi: assert() in iscsi_add_lun() Marc-André Lureau
2017-08-23 17:56   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 15/27] vhost-user-scsi: remove vdev_scsi_add_iscsi_lun() Marc-André Lureau
2017-08-23 17:57   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` Marc-André Lureau [this message]
2017-08-24  0:08   ` [Qemu-devel] [PATCH 16/27] vhost-user-scsi: remove VUS_MAX_LUNS Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 17/27] vhost-user-scsi: remove unimplemented functions Marc-André Lureau
2017-09-19 13:54   ` Paolo Bonzini
2017-08-23 16:19 ` [Qemu-devel] [PATCH 18/27] vhost-user-scsi: rename VUS types Marc-André Lureau
2017-08-23 17:59   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 19/27] vhost-user-scsi: avoid use of iscsi_ namespace Marc-André Lureau
2017-08-24  0:07   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 20/27] vhost-user-scsi: don't copy iscsi/scsi-lowlevel.h Marc-André Lureau
2017-09-12 16:41   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 21/27] vhost-user-scsi: drop extra callback pointer Marc-André Lureau
2017-08-23 23:59   ` Philippe Mathieu-Daudé
2017-08-23 16:19 ` [Qemu-devel] [PATCH 22/27] vhost-user-scsi: simplify source handling Marc-André Lureau
2017-09-19 14:45   ` Paolo Bonzini
2017-08-23 16:20 ` [Qemu-devel] [PATCH 23/27] vhost-user-scsi: use glib logging Marc-André Lureau
2017-08-24  0:00   ` Philippe Mathieu-Daudé
2017-08-23 16:20 ` [Qemu-devel] [PATCH 24/27] libvhost-user: add glib source helper Marc-André Lureau
2017-09-19 14:45   ` Paolo Bonzini
2017-09-19 15:04     ` Marc-André Lureau
2017-08-23 16:20 ` [Qemu-devel] [PATCH 25/27] build-sys: fix libvhost-user.a build Marc-André Lureau
2017-09-12 16:43   ` Philippe Mathieu-Daudé
2017-08-23 16:20 ` [Qemu-devel] [PATCH 26/27] vhost-user-scsi: use libvhost-user glib helper Marc-André Lureau
2017-08-23 16:20 ` [Qemu-devel] [PATCH 27/27] vhost-user-scsi: remove server_sock from VusDev Marc-André Lureau
2017-08-24  0:06   ` Philippe Mathieu-Daudé
2017-08-23 16:52 ` [Qemu-devel] [PATCH 00/27] vhost-user-scsi: code clean-up no-reply
2017-08-23 16:53 ` no-reply
2017-08-23 16:59 ` no-reply
2017-08-24  0:40 ` Liu, Changpeng
2017-09-11 13:18   ` Marc-André Lureau
2017-09-12  1:39     ` Liu, Changpeng
2017-09-19 12:45     ` Marc-André Lureau
2017-09-19 14:46       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823162004.27337-17-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=changpeng.liu@intel.com \
    --cc=felipe@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).