qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, maxime.coquelin@redhat.com,
	a.perevalov@samsung.com, mst@redhat.com,
	marcandre.lureau@redhat.com
Cc: quintela@redhat.com, peterx@redhat.com, lvivier@redhat.com,
	aarcange@redhat.com, felipe@nutanix.com
Subject: [Qemu-devel] [RFC v2 19/32] vhost+postcopy: Resolve client address
Date: Thu, 24 Aug 2017 20:27:17 +0100	[thread overview]
Message-ID: <20170824192730.8440-20-dgilbert@redhat.com> (raw)
In-Reply-To: <20170824192730.8440-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Resolve fault addresses read off the clients UFD into RAMBlock
and offset, and call back to the postcopy code to ask for the page.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hw/virtio/trace-events |  3 +++
 hw/virtio/vhost-user.c | 30 +++++++++++++++++++++++++++++-
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
index 5067dee19b..f7d4b831fe 100644
--- a/hw/virtio/trace-events
+++ b/hw/virtio/trace-events
@@ -1,6 +1,9 @@
 # See docs/devel/tracing.txt for syntax documentation.
 
 # hw/virtio/vhost-user.c
+vhost_user_postcopy_fault_handler(const char *name, uint64_t fault_address, int nregions) "%s: @0x%"PRIx64" nregions:%d"
+vhost_user_postcopy_fault_handler_loop(int i, uint64_t client_base, uint64_t size) "%d: client 0x%"PRIx64" +0x%"PRIx64
+vhost_user_postcopy_fault_handler_found(int i, uint64_t region_offset, uint64_t rb_offset) "%d: region_offset: 0x%"PRIx64" rb_offset:0x%"PRIx64
 vhost_user_postcopy_listen(void) ""
 vhost_user_set_mem_table_postcopy(uint64_t client_addr, uint64_t qhva, int reply_i, int region_i) "client:0x%"PRIx64" for hva: 0x%"PRIx64" reply %d region %d"
 vhost_user_set_mem_table_withfd(int index, const char *name, uint64_t memory_size, uint64_t guest_phys_addr, uint64_t userspace_addr, uint64_t offset) "%d:%s: size:0x%"PRIx64" GPA:0x%"PRIx64" QVA/userspace:0x%"PRIx64" RB offset:0x%"PRIx64
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index fbe2743298..2897ff70b3 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -816,7 +816,35 @@ out:
 static int vhost_user_postcopy_fault_handler(struct PostCopyFD *pcfd,
                                              void *ufd)
 {
-    return 0;
+    struct vhost_dev *dev = pcfd->data;
+    struct vhost_user *u = dev->opaque;
+    struct uffd_msg *msg = ufd;
+    uint64_t faultaddr = msg->arg.pagefault.address;
+    RAMBlock *rb = NULL;
+    uint64_t rb_offset;
+    int i;
+
+    trace_vhost_user_postcopy_fault_handler(pcfd->idstr, faultaddr,
+                                            dev->mem->nregions);
+    for (i = 0; i < MIN(dev->mem->nregions, u->region_rb_len); i++) {
+        trace_vhost_user_postcopy_fault_handler_loop(i,
+                u->postcopy_client_bases[i], dev->mem->regions[i].memory_size);
+        if (faultaddr >= u->postcopy_client_bases[i]) {
+            /* Ofset of the fault address in the vhost region */
+            uint64_t region_offset = faultaddr - u->postcopy_client_bases[i];
+            if (region_offset <= dev->mem->regions[i].memory_size) {
+                rb_offset = region_offset + u->region_rb_offset[i];
+                trace_vhost_user_postcopy_fault_handler_found(i,
+                        region_offset, rb_offset);
+                rb = u->region_rb[i];
+                return postcopy_request_shared_page(pcfd, rb, faultaddr,
+                                                    rb_offset);
+            }
+        }
+    }
+    error_report("%s: Failed to find region for fault %" PRIx64,
+                 __func__, faultaddr);
+    return -1;
 }
 
 /*
-- 
2.13.5

  parent reply	other threads:[~2017-08-24 19:29 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170824192750epcas5p484df9724ca7c0a259a4dd85425a69e1d@epcas5p4.samsung.com>
2017-08-24 19:26 ` [Qemu-devel] [RFC v2 00/32] postcopy+vhost-user/shared ram Dr. David Alan Gilbert (git)
2017-08-24 19:26   ` [Qemu-devel] [RFC v2 01/32] vhu: vu_queue_started Dr. David Alan Gilbert (git)
2017-08-24 23:10     ` Marc-André Lureau
2017-08-25 14:58       ` Dr. David Alan Gilbert
2017-08-30 13:02     ` Michael S. Tsirkin
2017-08-30 13:13       ` Marc-André Lureau
2017-09-05 12:58         ` Dr. David Alan Gilbert
2017-09-05 13:01           ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 02/32] vhub: Only process received packets on started queues Dr. David Alan Gilbert (git)
2017-08-30  9:59     ` Marc-André Lureau
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 03/32] migrate: Update ram_block_discard_range for shared Dr. David Alan Gilbert (git)
2017-08-29  5:30     ` Peter Xu
2017-09-18 12:18       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 04/32] qemu_ram_block_host_offset Dr. David Alan Gilbert (git)
2017-08-25 12:11     ` Philippe Mathieu-Daudé
2017-08-25 15:28       ` Dr. David Alan Gilbert
2017-08-29  5:36     ` Peter Xu
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 05/32] migration/ram: ramblock_recv_bitmap_test_byte_offset Dr. David Alan Gilbert (git)
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 06/32] postcopy: use UFFDIO_ZEROPAGE only when available Dr. David Alan Gilbert (git)
2017-08-30  9:57     ` Marc-André Lureau
2017-09-07 10:55       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 07/32] postcopy: Add notifier chain Dr. David Alan Gilbert (git)
2017-08-29  6:02     ` Peter Xu
2017-09-11 17:00       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 08/32] postcopy: Add vhost-user flag for postcopy and check it Dr. David Alan Gilbert (git)
2017-08-29  6:22     ` Peter Xu
2017-09-13 14:34       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 09/32] vhost-user: Add 'VHOST_USER_POSTCOPY_ADVISE' message Dr. David Alan Gilbert (git)
2017-08-30 10:07     ` Marc-André Lureau
2017-09-07 11:04       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 10/32] vhub: Support sending fds back to qemu Dr. David Alan Gilbert (git)
2017-08-30 10:22     ` Marc-André Lureau
2017-09-07 11:31       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 11/32] vhub: Open userfaultfd Dr. David Alan Gilbert (git)
2017-08-29  6:40     ` Peter Xu
2017-09-15 17:33       ` Dr. David Alan Gilbert
2017-08-30 10:30     ` Marc-André Lureau
2017-09-07 16:36       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 12/32] postcopy: Allow registering of fd handler Dr. David Alan Gilbert (git)
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 13/32] vhost+postcopy: Register shared ufd with postcopy Dr. David Alan Gilbert (git)
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 14/32] vhost+postcopy: Transmit 'listen' to client Dr. David Alan Gilbert (git)
2017-08-30 10:37     ` Marc-André Lureau
2017-09-07 12:10       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 15/32] vhost+postcopy: Register new regions with the ufd Dr. David Alan Gilbert (git)
2017-08-30 10:42     ` Marc-André Lureau
2017-09-08 14:50       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu Dr. David Alan Gilbert (git)
2017-08-29  8:30     ` Peter Xu
2017-09-12 17:15       ` Dr. David Alan Gilbert
2017-09-13  4:29         ` Peter Xu
2017-09-13 12:15           ` Dr. David Alan Gilbert
2017-09-15  8:57             ` Peter Xu
2017-09-15 15:32               ` Dr. David Alan Gilbert
2017-09-18  9:31               ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 17/32] vhost+postcopy: Stash RAMBlock and offset Dr. David Alan Gilbert (git)
2017-08-30  5:51     ` Peter Xu
2017-09-13 15:59       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 18/32] vhost+postcopy: Send requests to source for shared pages Dr. David Alan Gilbert (git)
2017-08-24 19:27   ` Dr. David Alan Gilbert (git) [this message]
2017-08-30  5:28     ` [Qemu-devel] [RFC v2 19/32] vhost+postcopy: Resolve client address Peter Xu
2017-09-11 11:58       ` Dr. David Alan Gilbert
2017-09-13  5:18         ` Peter Xu
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 20/32] postcopy: wake shared Dr. David Alan Gilbert (git)
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 21/32] postcopy: postcopy_notify_shared_wake Dr. David Alan Gilbert (git)
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 22/32] vhost+postcopy: Add vhost waker Dr. David Alan Gilbert (git)
2017-08-30  5:55     ` Peter Xu
2017-09-13 13:09       ` Dr. David Alan Gilbert
2017-09-18  3:57         ` Peter Xu
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 23/32] vhost+postcopy: Call wakeups Dr. David Alan Gilbert (git)
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 24/32] vub+postcopy: madvises Dr. David Alan Gilbert (git)
2017-08-30 10:48     ` Marc-André Lureau
2017-09-07 12:30       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 25/32] vhost+postcopy: Lock around set_mem_table Dr. David Alan Gilbert (git)
2017-08-30  6:50     ` Peter Xu
2017-09-25 17:56       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 26/32] vhost: Add VHOST_USER_POSTCOPY_END message Dr. David Alan Gilbert (git)
2017-08-30  6:55     ` Peter Xu
2017-09-11 11:31       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 27/32] vhost+postcopy: Wire up POSTCOPY_END notify Dr. David Alan Gilbert (git)
2017-08-30  6:57     ` Peter Xu
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 28/32] postcopy: Allow shared memory Dr. David Alan Gilbert (git)
2017-08-30 10:39     ` Marc-André Lureau
2017-09-07 12:15       ` Dr. David Alan Gilbert
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 29/32] vhost-user: Claim support for postcopy Dr. David Alan Gilbert (git)
2017-08-30 10:50     ` Marc-André Lureau
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 30/32] vhost: Merge neighbouring hugepage regions where appropriate Dr. David Alan Gilbert (git)
2017-09-14  9:18     ` Igor Mammedov
2017-09-25 11:19       ` Dr. David Alan Gilbert
2017-10-02 13:49         ` Igor Mammedov
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 31/32] vhost: Don't break merged regions on small remove/non-adds Dr. David Alan Gilbert (git)
2017-08-24 19:27   ` [Qemu-devel] [RFC v2 32/32] postcopy shared docs Dr. David Alan Gilbert (git)
2017-09-01 13:34   ` [Qemu-devel] [RFC v2 00/32] postcopy+vhost-user/shared ram Alexey Perevalov
2017-09-01 13:42     ` Maxime Coquelin
2017-10-16  8:32       ` Alexey Perevalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824192730.8440-20-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=a.perevalov@samsung.com \
    --cc=aarcange@redhat.com \
    --cc=felipe@nutanix.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).