qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, shorne@gmail.com, quintela@redhat.com,
	mreitz@redhat.com
Cc: peterx@redhat.com, lvivier@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event
Date: Fri, 25 Aug 2017 15:19:39 +0100	[thread overview]
Message-ID: <20170825141940.20740-2-dgilbert@redhat.com> (raw)
In-Reply-To: <20170825141940.20740-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

migration_incoming_state_destroy doesn't really destroy, it cleans up.
After a loadvm it's called, but the loadvm command can be run twice,
and so destroying an init-once mutex breaks on the second loadvm.

Reported-by: Stafford Horne <shorne@gmail.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/migration.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/migration.c b/migration/migration.c
index c3fe0ed9ca..a625551ce5 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -167,7 +167,7 @@ void migration_incoming_state_destroy(void)
         mis->from_src_file = NULL;
     }
 
-    qemu_event_destroy(&mis->main_thread_load_event);
+    qemu_event_reset(&mis->main_thread_load_event);
 }
 
 static void migrate_generate_event(int new_state)
-- 
2.13.5

  reply	other threads:[~2017-08-25 14:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 14:19 [Qemu-devel] [PATCH 0/2] Fix double loadvm failure Dr. David Alan Gilbert (git)
2017-08-25 14:19 ` Dr. David Alan Gilbert (git) [this message]
2017-08-25 15:28   ` [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event Peter Maydell
2017-08-25 15:51     ` Dr. David Alan Gilbert
2017-08-28  9:01       ` Peter Xu
2017-08-26 13:55   ` Stafford Horne
2017-08-28  9:08   ` Peter Xu
2017-08-25 14:19 ` [Qemu-devel] [PATCH 2/2] snapshot/tests: Try loadvm twice Dr. David Alan Gilbert (git)
2017-08-28  9:10   ` Peter Xu
2017-09-05 11:32     ` Dr. David Alan Gilbert
2017-09-06 14:19 ` [Qemu-devel] [PATCH 0/2] Fix double loadvm failure Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825141940.20740-2-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).