From: Eduardo Habkost <ehabkost@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Laine Stump <laine@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices
Date: Mon, 28 Aug 2017 10:33:42 -0300 [thread overview]
Message-ID: <20170828133342.GP15315@localhost.localdomain> (raw)
In-Reply-To: <8884ab94-9921-2eef-8d4f-a50c625e0f1c@redhat.com>
On Sun, Aug 27, 2017 at 11:35:56AM +0300, Marcel Apfelbaum wrote:
> Hi Eduardo,
>
> On 24/08/2017 1:14, Eduardo Habkost wrote:
> > Change all devices that set is_express=1 to implement
> > INTERFACE_PCIE_DEVICE.
> >
>
> Can this interface *replace* is_express field?
It can, but it has to be done carefully: 4 of the 5 hybrid
devices have is_express=0, so their logic need to be changed from
"set QEMU_PCI_CAP_EXPRESS manually if Express" to "clear
QEMU_PCI_CAP_EXPRESS manually if Conventional PCI".
Cleaning up the code on the hybrid devices is on my plans, but I
decided to do that after this series.
--
Eduardo
next prev parent reply other threads:[~2017-08-28 13:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 22:14 [Qemu-devel] [PATCH 0/5] Mark legacy/PCIe/hybrid PCI devices using interface names Eduardo Habkost
2017-08-23 22:14 ` [Qemu-devel] [PATCH 1/5] pci: INTERFACE_LEGACY_PCI_DEVICE and INTERFACE_PCIE_DEVICE interfaces Eduardo Habkost
2017-08-25 18:22 ` Alistair Francis
2017-08-25 20:19 ` Alex Williamson
2017-08-25 22:41 ` Eduardo Habkost
2017-08-23 22:14 ` [Qemu-devel] [PATCH 2/5] pci: Add interface names to hybrid PCI devices Eduardo Habkost
2017-08-25 19:18 ` Eduardo Habkost
2017-08-27 8:33 ` Marcel Apfelbaum
2017-08-28 17:59 ` Eduardo Habkost
2017-08-25 19:35 ` Eduardo Habkost
2017-08-27 7:48 ` Marcel Apfelbaum
2017-08-27 7:49 ` Marcel Apfelbaum
2017-08-23 22:14 ` [Qemu-devel] [PATCH 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices Eduardo Habkost
2017-08-25 18:22 ` Alistair Francis
2017-08-25 19:36 ` Eduardo Habkost
2017-08-27 8:35 ` Marcel Apfelbaum
2017-08-28 13:33 ` Eduardo Habkost [this message]
2017-08-23 22:14 ` [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices Eduardo Habkost
2017-08-25 19:39 ` Eduardo Habkost
2017-08-28 8:40 ` Alberto Garcia
2017-08-28 22:58 ` John Snow
2017-08-29 3:43 ` Eduardo Habkost
2017-09-25 14:32 ` Anthony PERARD
2017-08-23 22:14 ` [Qemu-devel] [PATCH 5/5] pci: Validate interfaces on base_class_init Eduardo Habkost
2017-08-25 18:25 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828133342.GP15315@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=laine@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).