From: Vadim Galitsyn <vadim.galitsyn@profitbricks.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
David Hildenbrand <david@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates
Date: Tue, 29 Aug 2017 17:30:19 +0200 [thread overview]
Message-ID: <20170829153022.27004-1-vadim.galitsyn@profitbricks.com> (raw)
Hi Guys,
Sorry for the delay. This is continuation of
http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02937.html.
I tried to update all the things according to your input
regarding to v6 series. I am attaching all the versions
history here in cover letter.
Best regards,
Vadim
v7:
* hmp: 'info numa': 'struct numa_node_mem' ->
'struct NumaNodeMem' (Eric);
* hmp: 'info numa': 'numa_node_mem.node_hotpluggable_mem' ->
'NumaNodeMem.node_plugged_mem' (in order to follow the same
naming schema as in the rest patches from this series);
* hmp: hmp_info_memory_size_summary() no longer
uses &error_abort (David);
* qmp: documented when @plugged-memory info is omitted (Eric);
* qmp: added example usage of @query-memory-size-summary (Eric);
* qmp: 'Since: 2.10.0' -> 'Since: 2.11.0' (Eric);
* All commit messages updated according to Eric's recomendation.
v6:
* qmp: Renamed get_existing_hotpluggable_memory_size() ->
get_plugged_memory_size();
* qmp: Renamed MemoryInfo.hotunpluggable_memory ->
MemoryInfo.plugged_memory;
* qmp: Dropped superfluous parenthesis around the
comparison while evaluating MemoryInfo.has_plugged_memory.
* hmp: Renamed 'info memory-size-summary' ->
'info memory_size_summary'
v5:
* hmp: Updated description and '.help' message for
'info memory-size-summary' command.
* hmp: Removed '-' characters from
'info memory-size-summary' output.
* Dropped ballooned memory information.
* get_existing_hotpluggable_memory_size() assumed
to never fail; routine now has no arguments and
returns uint64_t; in case if target does not support
memory hotplug, (uint64_t)-1 is returned.
* MemoryInfo structure:
* Removed @balloon-actual-memory field.
* Field @hotpluggable-memory renamed
to @hotunpluggable-memory.
* Updated description for fields.
* qmp: Updated description for
query-memory-size-summary.
* Patch v4 splitted into series.
v4:
* Commands "info memory" and "query-memory" were renamed
to "info memory-size-summary" and "query-memory-size-summary"
correspondingly.
* Descriptions for both commands as well as MemoryInfo structure
fields were updated/renamed according to
http://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg05972.html.
* In MemoryInfo structure following fields are now optional:
hotpluggable-memory and balloon-actual-memory.
* Field "hotpluggable-memory" now not displayed in HMP if target
has no CONFIG_MEM_HOTPLUG enabled.
* Field "balloon-actual-memory" now not displayed in HMP if
ballooning not enabled.
* qapi_free_MemoryInfo() used in order to free corresponding memory
instead of g_free().
* #ifdef CONFIG_MEM_HOTPLUG was removed and replaced with stubs/ approach.
get_exiting_hotpluggable_memory_size() function was introduced in
hw/mem/pc-dimm.c (available for all targets which have CONFIG_MEM_HOTPLUG
enabled). For other targets, there is a stub in stubs/qmp_pc_dimm.c.
In addition, stubs/qmp_pc_dimm_device_list.c was renamed to
stubs/qmp_pc_dimm.c in order to reflect actual source file content.
* Commit message was updated in order to reflect what was changed.
v3:
* Use PRIu64 instead of 'lu' when printing results via HMP.
* Report zero hot-plugged memory instead of reporting error
when target architecture has no CONFIG_MEM_HOTPLUG enabled.
v2:
* Fixed build for targets which do not have CONFIG_MEM_HOTPLUG
enabled.
next reply other threads:[~2017-08-29 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 15:30 Vadim Galitsyn [this message]
2017-08-29 15:30 ` [Qemu-devel] [PATCH v7 1/3] hmp: extend "info numa" with hotplugged memory information Vadim Galitsyn
2017-08-29 15:30 ` [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command Vadim Galitsyn
2017-09-14 9:57 ` Igor Mammedov
2017-09-14 10:26 ` Dr. David Alan Gilbert
2017-09-14 10:31 ` Vadim Galitsyn
2017-09-14 11:06 ` Dr. David Alan Gilbert
2017-08-29 15:30 ` [Qemu-devel] [PATCH v7 3/3] hmp: introduce 'info memory_size_summary' command Vadim Galitsyn
2017-09-14 10:00 ` Igor Mammedov
2017-09-14 9:35 ` [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates Vadim Galitsyn
2017-09-14 10:02 ` Igor Mammedov
2017-09-14 10:09 ` Dr. David Alan Gilbert
2017-09-14 10:25 ` Vadim Galitsyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829153022.27004-1-vadim.galitsyn@profitbricks.com \
--to=vadim.galitsyn@profitbricks.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).