From: Stefan Hajnoczi <stefanha@gmail.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, f4bug@amsat.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/9] IDE: replace printfs with tracing
Date: Wed, 30 Aug 2017 10:21:56 +0100 [thread overview]
Message-ID: <20170830092156.GE24565@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170829204934.9039-1-jsnow@redhat.com>
On Tue, Aug 29, 2017 at 04:49:25PM -0400, John Snow wrote:
> Wherever possible, replace all printfs with proper tracing.
> In most places I've tried to do a straight replacement, but
> forthcoming patches may calibrate the tracing to be a little nicer.
>
> For now, it's nice to just remove the all-or-nothing tracing.
>
> For V2, I opted to leave in the nearly redundant tracers for now
> with their individual names so that they can be targeted individually.
Looks good. I left a comment on one patch.
prev parent reply other threads:[~2017-08-30 9:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 20:49 [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing John Snow
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 1/9] IDE: replace DEBUG_IDE with tracing system John Snow
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 2/9] IDE: Add register hints to tracing John Snow
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 3/9] IDE: add tracing for data ports John Snow
2017-08-29 22:20 ` Philippe Mathieu-Daudé
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events John Snow
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 5/9] IDE: replace DEBUG_AIO with trace events John Snow
2017-08-30 3:14 ` Philippe Mathieu-Daudé
2017-08-30 23:25 ` John Snow
2017-08-31 16:19 ` Laszlo Ersek
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 6/9] AHCI: Replace DPRINTF with trace-events John Snow
2017-08-29 22:22 ` Philippe Mathieu-Daudé
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 7/9] AHCI: Rework IRQ constants John Snow
2017-08-30 3:54 ` Philippe Mathieu-Daudé
2017-08-30 23:28 ` John Snow
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 8/9] AHCI: pretty-print FIS to buffer instead of stderr John Snow
2017-08-30 9:17 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-30 22:50 ` John Snow
2017-08-29 20:49 ` [Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro John Snow
2017-08-29 22:24 ` Philippe Mathieu-Daudé
2017-08-29 21:14 ` [Qemu-devel] [PATCH v2 0/9] IDE: replace printfs with tracing no-reply
2017-08-30 9:21 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830092156.GE24565@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).