From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn4c1-0001Fr-Ti for qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn4by-0007qf-FO for qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:09:01 -0400 Date: Wed, 30 Aug 2017 17:08:50 +0200 From: Cornelia Huck Message-ID: <20170830170850.631d1f8c.cohuck@redhat.com> In-Reply-To: <1504030416-18618-1-git-send-email-thuth@redhat.com> References: <1504030416-18618-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken ivshmem-server-msi/-irq tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Laurent Vivier , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , David Gibson On Tue, 29 Aug 2017 20:13:36 +0200 Thomas Huth wrote: > Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take > opaque BAR handle") a while ago, but nobody noticed since the tests are > only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized > anymore if bir_pba has the same value as bir_table. With this fix, > "make check SPEED=slow" should work fine again. > > Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b > Signed-off-by: Thomas Huth > --- > tests/libqos/pci.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) With that (and "hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems"), "make check SPEED=slow" now works for me both on x86_64 and s390x, so Tested-by: Cornelia Huck