qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Yongbok Kim <yongbok.kim@imgtec.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 4/7] hw/mips/malta: use serial_chr_nonnull()
Date: Thu, 31 Aug 2017 00:53:03 -0300	[thread overview]
Message-ID: <20170831035306.29170-5-f4bug@amsat.org> (raw)
In-Reply-To: <20170831035306.29170-1-f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/mips/mips_malta.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index af678f5784..8620e9c42c 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1035,11 +1035,7 @@ void mips_malta_init(MachineState *machine)
 
     /* Make sure the first 3 serial ports are associated with a device. */
     for(i = 0; i < 3; i++) {
-        if (!serial_hds[i]) {
-            char label[32];
-            snprintf(label, sizeof(label), "serial%d", i);
-            serial_hds[i] = qemu_chr_new(label, "null");
-        }
+        serial_hds[i] = serial_chr_nonnull(serial_hds[i]);
     }
 
     /* create CPU */
-- 
2.14.1

  parent reply	other threads:[~2017-08-31  3:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31  3:52 [Qemu-devel] [PATCH 0/7] serial: add serial_chr_nonnull() Philippe Mathieu-Daudé
2017-08-31  3:53 ` [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided Philippe Mathieu-Daudé
2017-08-31  5:19   ` Thomas Huth
2017-08-31  9:36     ` Marc-André Lureau
2017-08-31  9:43       ` Thomas Huth
2017-08-31 15:24         ` Philippe Mathieu-Daudé
2017-09-01  9:12           ` Markus Armbruster
2017-08-31 15:20     ` Philippe Mathieu-Daudé
2017-08-31 15:23       ` Thomas Huth
2017-08-31 10:28   ` Peter Maydell
2017-08-31 15:17     ` Philippe Mathieu-Daudé
2017-08-31  3:53 ` [Qemu-devel] [PATCH 2/7] serial: use serial_chr_nonnull() in serial_mm_init() Philippe Mathieu-Daudé
2017-08-31  3:53 ` [Qemu-devel] [PATCH 3/7] hw/arm/fsl_imx*: use serial_chr_nonnull() Philippe Mathieu-Daudé
2017-08-31  3:53 ` Philippe Mathieu-Daudé [this message]
2017-08-31  3:53 ` [Qemu-devel] [PATCH 5/7] hw/char/exynos4210_uart: " Philippe Mathieu-Daudé
2017-08-31  3:53 ` [Qemu-devel] [PATCH 6/7] hw/char/omap_uart: serial_mm_init() already check for null chr Philippe Mathieu-Daudé
2017-08-31  3:53 ` [Qemu-devel] [PATCH 7/7] hw/xtensa: " Philippe Mathieu-Daudé
2017-09-05 14:56 ` [Qemu-devel] [PATCH 0/7] serial: add serial_chr_nonnull() Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831035306.29170-5-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aurelien@aurel32.net \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=yongbok.kim@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).