From: Stefan Hajnoczi <stefanha@gmail.com>
To: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page tracking
Date: Thu, 31 Aug 2017 09:20:15 +0100 [thread overview]
Message-ID: <20170831082015.GF13619@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170830082702.3011-11-Sergio.G.DelReal@gmail.com>
On Wed, Aug 30, 2017 at 03:26:59AM -0500, Sergio Andres Gomez Del Real wrote:
> +static void hvf_log_start(MemoryListener *listener,
> + MemoryRegionSection *section, int old, int new)
> +{
> + if (old != 0)
> + return;
QEMU coding style uses curly braces even when the if statement body only
has 1 line.
> +
> + hvf_set_dirty_tracking(section, 1);
> +}
> +
> +static void hvf_log_stop(MemoryListener *listener,
> + MemoryRegionSection *section, int old, int new)
> +{
> + if (new != 0)
> + return;
Same here.
next prev parent reply other threads:[~2017-08-31 8:20 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 8:26 [Qemu-devel] [PATCH v2 00/13] add support for Hypervisor.framework in QEMU Sergio Andres Gomez Del Real
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 01/13] hvf: add support for Hypervisor.framework in the configure script Sergio Andres Gomez Del Real
2017-08-30 10:18 ` Stefan Hajnoczi
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository Sergio Andres Gomez Del Real
2017-08-30 14:07 ` Daniel P. Berrange
2017-08-31 7:42 ` Stefan Hajnoczi
2017-08-31 11:26 ` Paolo Bonzini
2017-08-31 12:01 ` Izik Eidus
2017-08-31 21:21 ` Paolo Bonzini
2017-08-31 21:39 ` Izik Eidus
2017-09-03 16:16 ` Izik Eidus
2017-09-03 16:35 ` Paolo Bonzini
2017-09-03 16:53 ` Izik Eidus
[not found] ` <CABgObfaDuLvaxpb-GmefsNcoUsjJi3y_oAnfYuQU8LQcGtx9zQ@mail.gmail.com>
2017-09-03 17:13 ` Paolo Bonzini
2017-09-03 18:49 ` Izik Eidus
[not found] ` <CABgObfZTRAF7NJea=-SyNy67ZXFZVgoQLRjgswvPSs14euq+zw@mail.gmail.com>
2017-09-04 6:47 ` Paolo Bonzini
2017-09-06 13:28 ` Izik Eidus
[not found] ` <CABgObfac1_DfU1JSu6AeocYQWEqQURxdFt2JPDHzEXG15EOPwQ@mail.gmail.com>
2017-09-06 14:28 ` Paolo Bonzini
2017-09-06 14:45 ` Izik Eidus
2017-08-31 21:41 ` Sergio Andrés Gómez del Real
2017-08-31 22:02 ` Frank Yang
2017-08-31 22:10 ` Izik Eidus
2017-09-01 9:18 ` Daniel P. Berrange
2017-09-01 17:59 ` Izik Eidus
2017-09-03 6:23 ` Paolo Bonzini
2017-09-03 13:00 ` Izik Eidus
2017-09-03 16:33 ` Sergio Andrés Gómez del Real
2017-09-03 16:38 ` Sergio Andrés Gómez del Real
2017-09-03 2:26 ` Izik Eidus
2017-08-31 7:54 ` Stefan Hajnoczi
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 03/13] hvf: add compilation rules to Makefile.objs Sergio Andres Gomez Del Real
2017-08-30 10:22 ` Stefan Hajnoczi
2017-08-30 10:26 ` Stefan Hajnoczi
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 04/13] hvf: run hvf code through checkpatch.pl and fix style issues Sergio Andres Gomez Del Real
2017-08-31 8:01 ` Stefan Hajnoczi
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 05/13] hvf: add fields to CPUState and CPUX86State; add definitions Sergio Andres Gomez Del Real
2017-08-30 10:24 ` Stefan Hajnoczi
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 06/13] hvf: use new helper functions for put/get xsave Sergio Andres Gomez Del Real
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 07/13] apic: add function to apic that will be used by hvf Sergio Andres Gomez Del Real
2017-08-31 8:07 ` Stefan Hajnoczi
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 08/13] hvf: implement hvf_get_supported_cpuid Sergio Andres Gomez Del Real
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 09/13] hvf: refactor cpuid code Sergio Andres Gomez Del Real
2017-08-31 8:12 ` Stefan Hajnoczi
2017-08-30 8:26 ` [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page tracking Sergio Andres Gomez Del Real
2017-08-31 8:20 ` Stefan Hajnoczi [this message]
2017-08-30 8:27 ` [Qemu-devel] [PATCH v2 11/13] hvf: move fields from CPUState to CPUX86State Sergio Andres Gomez Del Real
2017-08-31 9:18 ` Stefan Hajnoczi
2017-08-30 8:27 ` [Qemu-devel] [PATCH v2 12/13] hvf: refactor event injection code for hvf Sergio Andres Gomez Del Real
2017-08-30 8:27 ` [Qemu-devel] [PATCH v2 13/13] hvf: inject General Protection Fault when vmexit through vmcall Sergio Andres Gomez Del Real
2017-08-30 13:49 ` [Qemu-devel] [PATCH v2 00/13] add support for Hypervisor.framework in QEMU no-reply
2017-08-30 14:14 ` no-reply
2017-08-31 9:34 ` Stefan Hajnoczi
2017-09-08 21:49 ` Sergio Andrés Gómez del Real
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831082015.GF13619@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sergio.g.delreal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).