From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnZ1D-0002j5-2A for qemu-devel@nongnu.org; Thu, 31 Aug 2017 19:37:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnZ18-00037m-Aa for qemu-devel@nongnu.org; Thu, 31 Aug 2017 19:37:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37056) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnZ18-00037E-4i for qemu-devel@nongnu.org; Thu, 31 Aug 2017 19:36:58 -0400 Date: Thu, 31 Aug 2017 20:36:50 -0300 From: Eduardo Habkost Message-ID: <20170831233650.GH7570@localhost.localdomain> References: <20170818170526.13496-1-apahim@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170818170526.13496-1-apahim@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amador Pahim Cc: qemu-devel@nongnu.org, kwolf@redhat.com, ldoktor@redhat.com, famz@redhat.com, stefanha@gmail.com, armbru@redhat.com, mreitz@redhat.com, crosa@redhat.com I was going to queue most of this series except patch 02/11 due the "qemu received signal" message log level, but a few conflicts prevent the rest of the series from applying cleanly. Are you planning to send v8? On Fri, Aug 18, 2017 at 07:05:15PM +0200, Amador Pahim wrote: > Changes v1->v2: > - Style fixes to make checkpatch.pl happy. > - Rebased. > Changes v2->v3: > - Fix typo in patch 3 ("qemu.py: make 'args' public") commit message. > Changes v3->v4: > - Squash the 2 first commits since they are co-dependant. > - Cleanup launch() and shutdown(). > - Reorder the commits, putting the rename of self._args first. > - Rebased. > Changes v4->v5: > - Break the cleanup commit into logical changes and include in the > commit messages the rationale for making them. > Changes v5->v6: > - Remove the commit to rename self._args. > - Fix is_running() return before first call to maunch(). > - Use python logging system. > - Include the full command line on negative exit code error message. > - Use os.path.null instead of /dev/null. > - Improve the control over the created/deleted files. > Changes v6->v7: > - Split commits in self-contained/atomic changes. > - Addressed the comments from previous version, basically improving the > logging messages and the control over created files. See individual > commit messages for details. > > Amador Pahim (11): > qemu.py: fix is_running() return before first launch() > qemu.py: avoid writing to stdout/stderr > qemu.py: use os.path.null instead of /dev/null > qemu.py: use poll() instead of 'returncode' > qemu.py: cleanup redundant calls in launch() > qemu.py: improve message on negative exit code > qemu.py: include debug information on launch error > qemu.py: make sure we only remove files we create > qemu.py: launch vm only if it's not running > qemu.py: don't launch again before shutdown() > qemu.py: refactor launch() > > scripts/qemu.py | 141 ++++++++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 106 insertions(+), 35 deletions(-) > > -- > 2.13.5 > > -- Eduardo