qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: eblake@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	f4bug@amsat.org, John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v3 9/9] AHCI: remove DPRINTF macro
Date: Thu, 31 Aug 2017 20:15:02 -0400	[thread overview]
Message-ID: <20170901001502.29915-10-jsnow@redhat.com> (raw)
In-Reply-To: <20170901001502.29915-1-jsnow@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: John Snow <jsnow@redhat.com>
---
 hw/ide/ahci.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 6c98047..14b71a3 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -34,17 +34,8 @@
 #include "hw/ide/pci.h"
 #include "hw/ide/ahci_internal.h"
 
-#define DEBUG_AHCI 0
 #include "trace.h"
 
-#define DPRINTF(port, fmt, ...) \
-do { \
-    if (DEBUG_AHCI) { \
-        fprintf(stderr, "ahci: %s: [%d] ", __func__, port); \
-        fprintf(stderr, fmt, ## __VA_ARGS__); \
-    } \
-} while (0)
-
 static void check_cmd(AHCIState *s, int port);
 static int handle_cmd(AHCIState *s, int port, uint8_t slot);
 static void ahci_reset_port(AHCIState *s, int port);
-- 
2.9.5

  parent reply	other threads:[~2017-09-01  0:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01  0:14 [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing John Snow
2017-09-01  0:14 ` [Qemu-devel] [PATCH v3 1/9] IDE: replace DEBUG_IDE with tracing system John Snow
2017-09-01  0:14 ` [Qemu-devel] [PATCH v3 2/9] IDE: Add register hints to tracing John Snow
2017-09-01  0:14 ` [Qemu-devel] [PATCH v3 3/9] IDE: add tracing for data ports John Snow
2017-09-01  0:14 ` [Qemu-devel] [PATCH v3 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events John Snow
2017-09-01  0:14 ` [Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events John Snow
2017-09-01  0:27   ` Philippe Mathieu-Daudé
2017-09-01  0:40     ` John Snow
2017-09-01  0:14 ` [Qemu-devel] [PATCH v3 6/9] AHCI: Replace DPRINTF with trace-events John Snow
2017-09-01  0:15 ` [Qemu-devel] [PATCH v3 7/9] AHCI: Rework IRQ constants John Snow
2017-09-01  0:15 ` [Qemu-devel] [PATCH v3 8/9] AHCI: pretty-print FIS to buffer instead of stderr John Snow
2017-09-01  0:15 ` John Snow [this message]
2017-09-01  0:27 ` [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing no-reply
2017-09-01  0:37   ` John Snow
2017-09-01 10:56 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-09-01 18:57   ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170901001502.29915-10-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=eblake@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).