From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnirh-0004kX-3k for qemu-devel@nongnu.org; Fri, 01 Sep 2017 06:07:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnirX-0001PM-KP for qemu-devel@nongnu.org; Fri, 01 Sep 2017 06:07:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50950) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnirX-0001PF-Dd for qemu-devel@nongnu.org; Fri, 01 Sep 2017 06:07:43 -0400 Date: Fri, 1 Sep 2017 11:07:36 +0100 From: "Daniel P. Berrange" Message-ID: <20170901100736.GH31680@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170831112210.19921-1-famz@redhat.com> <20170831112210.19921-4-famz@redhat.com> <09158e7a-0c19-1573-5eaf-e90eed0b59ed@redhat.com> <20170901095552.GE4330@lemon.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170901095552.GE4330@lemon.lan> Subject: Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Eric Blake , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= On Fri, Sep 01, 2017 at 05:55:52PM +0800, Fam Zheng wrote: > On Thu, 08/31 11:06, Eric Blake wrote: > > On 08/31/2017 06:22 AM, Fam Zheng wrote: > > > Signed-off-by: Fam Zheng > > > --- > > > tests/docker/test-block | 21 +++++++++++++++++++++ > > > 1 file changed, 21 insertions(+) > > > create mode 100755 tests/docker/test-block > > > > > > > +cd "$BUILD_DIR" > > > + > > > +build_qemu --target-list=x86_64-softmmu > > > +cd tests/qemu-iotests > > > +./check -raw > > > +./check -qcow2 > > > > Should we also run ./check -nbd? > > Yes, I can add it, and -g quick to all formats, so that the whole test is not > lagged too badly, and that writing "quick" tests is encouraged in some degree. If you also add a "daily" test, you could make the daily one run all tests, while the per-commit one just uses 'quick'. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|