From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH 2/2] iotests: blacklist 194 with the luks driver
Date: Fri, 1 Sep 2017 11:54:34 +0100 [thread overview]
Message-ID: <20170901105434.3288-3-berrange@redhat.com> (raw)
In-Reply-To: <20170901105434.3288-1-berrange@redhat.com>
The 194 test has alot of code that assumes a simple image file. Rewriting
this to work with luks is possible, but non-trivial, so blacklist the
luks format for now.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
tests/qemu-iotests/194 | 1 +
tests/qemu-iotests/iotests.py | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194
index a3e3bad664..bfe1859ecf 100755
--- a/tests/qemu-iotests/194
+++ b/tests/qemu-iotests/194
@@ -23,6 +23,7 @@ import os
import atexit
import iotests
+iotests.verify_image_format(unsupported_fmts=['luks'])
iotests.verify_platform(['linux'])
img_size = '1G'
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 7233983f3c..3e7304b678 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -395,9 +395,11 @@ def notrun(reason):
print '%s not run: %s' % (seq, reason)
sys.exit(0)
-def verify_image_format(supported_fmts=[]):
+def verify_image_format(supported_fmts=[], unsupported_fmts=[]):
if supported_fmts and (imgfmt not in supported_fmts):
notrun('not suitable for this image format: %s' % imgfmt)
+ if unsupported_fmts and (imgfmt in unsupported_fmts):
+ notrun('not suitable for this image format: %s' % imgfmt)
def verify_platform(supported_oses=['linux']):
if True not in [sys.platform.startswith(x) for x in supported_oses]:
--
2.13.5
next prev parent reply other threads:[~2017-09-01 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 10:54 [Qemu-devel] [PATCH 0/2] Fix / skip recent iotests with LUKS driver Daniel P. Berrange
2017-09-01 10:54 ` [Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use _launch_qemu to fix LUKS support Daniel P. Berrange
2017-09-01 14:22 ` Eric Blake
2017-09-05 9:29 ` Kevin Wolf
2017-09-01 10:54 ` Daniel P. Berrange [this message]
2017-09-01 14:25 ` [Qemu-devel] [PATCH 2/2] iotests: blacklist 194 with the luks driver Eric Blake
2017-09-04 9:14 ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
2017-09-05 10:04 ` Stefan Hajnoczi
2017-09-01 14:26 ` [Qemu-devel] [PATCH 0/2] Fix / skip recent iotests with LUKS driver Eric Blake
2017-09-01 14:33 ` Daniel P. Berrange
2017-09-01 20:10 ` Eric Blake
2017-09-01 14:55 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901105434.3288-3-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).