From: Eduardo Otubo <otubo@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mst@redhat.com, pbonzini@redhat.com,
ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
Date: Fri, 1 Sep 2017 13:03:32 +0200 [thread overview]
Message-ID: <20170901110332.32650-1-otubo@redhat.com> (raw)
When used with the following command line:
./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
QEMU with machine type 40p already creates the device i82374. If
specified in the command line, it will try to create it again, hence
generating the error. One way to avoid this problem is to set
user_creatable=false.
Signed-off-by: Eduardo Otubo <otubo@redhat.com>
---
hw/dma/i82374.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
index 6c0f975df0..5275d822e0 100644
--- a/hw/dma/i82374.c
+++ b/hw/dma/i82374.c
@@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)
dc->realize = i82374_realize;
dc->vmsd = &vmstate_i82374;
dc->props = i82374_properties;
+ dc->user_creatable = false;
}
static const TypeInfo i82374_info = {
--
2.13.5
next reply other threads:[~2017-09-01 11:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 11:03 Eduardo Otubo [this message]
2017-09-01 14:30 ` [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device Eduardo Habkost
2017-09-01 15:34 ` Markus Armbruster
2017-09-01 15:44 ` Eduardo Habkost
2017-09-07 8:38 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
2017-09-09 21:52 ` Eduardo Habkost
2017-09-02 9:15 ` [Qemu-devel] " Aurelien Jarno
2017-09-07 8:38 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
2017-09-07 16:05 ` [Qemu-devel] " Paolo Bonzini
2017-09-08 7:57 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
-- strict thread matches above, loose matches on Subject: below --
2017-09-15 9:06 [Qemu-devel] " Eduardo Otubo
2017-09-15 10:18 ` Paolo Bonzini
2017-09-15 11:53 ` Eduardo Otubo
2017-09-15 22:21 ` Eduardo Habkost
2017-09-16 8:09 ` Paolo Bonzini
2017-09-24 21:02 ` [Qemu-devel] [[PATCH] " Michael Tokarev
2017-09-25 9:11 ` Paolo Bonzini
2017-09-25 9:26 ` Eduardo Otubo
2017-09-25 9:36 ` Paolo Bonzini
2017-09-25 10:54 ` [Qemu-devel] [PATCH] " Michael Tokarev
2017-09-25 11:25 ` Paolo Bonzini
2018-03-26 11:18 Eduardo Otubo
2018-03-26 12:14 ` Thomas Huth
2018-03-26 12:16 ` Paolo Bonzini
2018-03-26 15:20 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901110332.32650-1-otubo@redhat.com \
--to=otubo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).