qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, famz@redhat.com, berrange@redhat.com,
	ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
	armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com,
	Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown()
Date: Fri,  1 Sep 2017 13:28:25 +0200	[thread overview]
Message-ID: <20170901112829.2571-10-apahim@redhat.com> (raw)
In-Reply-To: <20170901112829.2571-1-apahim@redhat.com>

Currently we only cleanup on shutdown() if the VM is running.

To make sure we will always cleanup, this patch makes the cleanup to
always happen in shutdown, regardless the VM running state.

Signed-off-by: Amador Pahim <apahim@redhat.com>
---
 scripts/qemu.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/qemu.py b/scripts/qemu.py
index 06f07bfaa2..ede734328b 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -205,8 +205,8 @@ class QEMUMachine(object):
                 self._popen.kill()
             self._popen.wait()
 
-            self._load_io_log()
-            self._post_shutdown()
+        self._load_io_log()
+        self._post_shutdown()
 
         exitcode = self.exitcode()
         if exitcode is not None and exitcode < 0:
-- 
2.13.5

  parent reply	other threads:[~2017-09-01 11:32 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01 11:28 [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups Amador Pahim
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 01/13] qemu.py: fix is_running() return before first launch() Amador Pahim
2017-09-05  2:57   ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 02/13] qemu.py: avoid writing to stdout/stderr Amador Pahim
2017-09-05  2:59   ` Fam Zheng
2017-09-21 10:35   ` Kevin Wolf
2017-09-21 12:17     ` Eduardo Habkost
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 03/13] qemu.py: use os.path.null instead of /dev/null Amador Pahim
2017-09-01 11:39   ` Philippe Mathieu-Daudé
2017-09-05  2:59   ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code Amador Pahim
2017-09-05  3:02   ` Fam Zheng
2017-09-18  5:18     ` Kevin Wolf
2017-09-18  5:39       ` Fam Zheng
2017-09-18  6:44         ` Kevin Wolf
2017-09-18  7:03           ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error Amador Pahim
2017-09-05  3:05   ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create Amador Pahim
2017-09-05  3:18   ` Fam Zheng
2017-09-14 19:38     ` Amador Pahim
2017-09-14 19:46       ` Eduardo Habkost
2017-09-14 20:05         ` Amador Pahim
2017-09-14 20:18           ` Eduardo Habkost
2017-09-14 20:21             ` Amador Pahim
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup Amador Pahim
2017-09-05  3:05   ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 08/13] qemu.py: refactor launch() Amador Pahim
2017-09-05  3:06   ` Fam Zheng
2017-09-01 11:28 ` Amador Pahim [this message]
2017-09-05  3:07   ` [Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown() Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-09-05  3:07   ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 11/13] qemu.py: cleanup redundant calls in launch() Amador Pahim
2017-09-05  3:20   ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 12/13] qemu.py: launch vm only if it's not running Amador Pahim
2017-09-05  3:19   ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again before shutdown() Amador Pahim
2017-09-05  3:22   ` Fam Zheng
2017-09-05 10:02 ` [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups Stefan Hajnoczi
2017-09-14 19:31 ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170901112829.2571-10-apahim@redhat.com \
    --to=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).