From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 25/29] lm32: replace cpu_lm32_init() with cpu_generic_init()
Date: Fri, 1 Sep 2017 12:03:13 -0300 [thread overview]
Message-ID: <20170901150317.10380-26-ehabkost@redhat.com> (raw)
In-Reply-To: <20170901150317.10380-1-ehabkost@redhat.com>
From: Igor Mammedov <imammedo@redhat.com>
it's just a wrapper, drop it and use cpu_generic_init() directly
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Michael Walle <michael@walle.cc>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <1503592308-93913-22-git-send-email-imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/lm32/cpu.h | 3 +--
hw/lm32/lm32_boards.c | 4 ++--
hw/lm32/milkymist.c | 2 +-
target/lm32/helper.c | 5 -----
4 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/target/lm32/cpu.h b/target/lm32/cpu.h
index 1d972cb26b..de265b50d1 100644
--- a/target/lm32/cpu.h
+++ b/target/lm32/cpu.h
@@ -238,7 +238,6 @@ static inline lm32_wp_t lm32_wp_type(uint32_t dc, int idx)
return (dc >> (idx+1)*2) & 0x3;
}
-LM32CPU *cpu_lm32_init(const char *cpu_model);
/* you can call this signal handler from your SIGBUS and SIGSEGV
signal handlers to inform the virtual CPU of exceptions. non zero
is returned if the signal was handled by the virtual CPU. */
@@ -256,7 +255,7 @@ void lm32_watchpoint_insert(CPULM32State *env, int index, target_ulong address,
void lm32_watchpoint_remove(CPULM32State *env, int index);
bool lm32_cpu_do_semihosting(CPUState *cs);
-#define cpu_init(cpu_model) CPU(cpu_lm32_init(cpu_model))
+#define cpu_init(cpu_model) cpu_generic_init(TYPE_LM32_CPU, cpu_model)
#define cpu_list lm32_cpu_list
#define cpu_signal_handler cpu_lm32_signal_handler
diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c
index 8f0c3079d6..eccf0ac5a1 100644
--- a/hw/lm32/lm32_boards.c
+++ b/hw/lm32/lm32_boards.c
@@ -104,7 +104,7 @@ static void lm32_evr_init(MachineState *machine)
if (cpu_model == NULL) {
cpu_model = "lm32-full";
}
- cpu = cpu_lm32_init(cpu_model);
+ cpu = LM32_CPU(cpu_generic_init(TYPE_LM32_CPU, cpu_model));
if (cpu == NULL) {
fprintf(stderr, "qemu: unable to find CPU '%s'\n", cpu_model);
exit(1);
@@ -205,7 +205,7 @@ static void lm32_uclinux_init(MachineState *machine)
if (cpu_model == NULL) {
cpu_model = "lm32-full";
}
- cpu = cpu_lm32_init(cpu_model);
+ cpu = LM32_CPU(cpu_generic_init(TYPE_LM32_CPU, cpu_model));
if (cpu == NULL) {
fprintf(stderr, "qemu: unable to find CPU '%s'\n", cpu_model);
exit(1);
diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
index 5cae0f19dd..dffd8797bb 100644
--- a/hw/lm32/milkymist.c
+++ b/hw/lm32/milkymist.c
@@ -111,7 +111,7 @@ milkymist_init(MachineState *machine)
if (cpu_model == NULL) {
cpu_model = "lm32-full";
}
- cpu = cpu_lm32_init(cpu_model);
+ cpu = LM32_CPU(cpu_generic_init(TYPE_LM32_CPU, cpu_model));
if (cpu == NULL) {
fprintf(stderr, "qemu: unable to find CPU '%s'\n", cpu_model);
exit(1);
diff --git a/target/lm32/helper.c b/target/lm32/helper.c
index 891da18c30..929cc36c14 100644
--- a/target/lm32/helper.c
+++ b/target/lm32/helper.c
@@ -219,11 +219,6 @@ bool lm32_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
return false;
}
-LM32CPU *cpu_lm32_init(const char *cpu_model)
-{
- return LM32_CPU(cpu_generic_init(TYPE_LM32_CPU, cpu_model));
-}
-
/* Some soc ignores the MSB on the address bus. Thus creating a shadow memory
* area. As a general rule, 0x00000000-0x7fffffff is cached, whereas
* 0x80000000-0xffffffff is not cached and used to access IO devices. */
--
2.13.5
next prev parent reply other threads:[~2017-09-01 15:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 15:02 [Qemu-devel] [PULL 00/29] x86 & cpu queue, 2017-09-01 Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 01/29] qom: Remove unused errp parameter from can_be_deleted() Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 02/29] cpu: cpu_by_arch_id() helper Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 03/29] hmp: allow apic-id for "info lapic" Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 04/29] target-i386/cpu: Add new EPYC CPU model Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 05/29] qom: cpu: fix parsed feature string length Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 06/29] sparc: convert cpu models to SPARC cpu subclasses Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 07/29] sparc: embed sparc_def_t into CPUSPARCState Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 08/29] sparc: convert cpu features to qdev properties Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 09/29] sparc: move adhoc CPUSPARCState initialization to realize time Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 10/29] sparc: make cpu feature parsing property based Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 11/29] sparc: replace cpu_sparc_init() with cpu_generic_init() Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 12/29] s390x: replace cpu_s390x_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 13/29] alpha: replace cpu_alpha_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 14/29] hppa: replace cpu_hppa_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 15/29] m68k: replace cpu_m68k_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 16/29] microblaze: replace cpu_mb_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 17/29] nios2: replace cpu_nios2_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 18/29] tilegx: replace cpu_tilegx_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 19/29] xtensa: replace cpu_xtensa_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 20/29] tricore: replace cpu_tricore_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 21/29] sh4: replace cpu_sh4_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 22/29] arm: replace cpu_arm_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 23/29] cris: replace cpu_cris_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 24/29] x86: replace cpu_x86_init() " Eduardo Habkost
2017-09-01 15:03 ` Eduardo Habkost [this message]
2017-09-01 15:03 ` [Qemu-devel] [PULL 26/29] moxie: replace cpu_moxie_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 27/29] openrisc: replace cpu_openrisc_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 28/29] unicore32: replace uc32_cpu_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 29/29] ppc: replace cpu_ppc_init() " Eduardo Habkost
2017-09-04 8:41 ` [Qemu-devel] [PULL 00/29] x86 & cpu queue, 2017-09-01 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901150317.10380-26-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).