From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 26/29] moxie: replace cpu_moxie_init() with cpu_generic_init()
Date: Fri, 1 Sep 2017 12:03:14 -0300 [thread overview]
Message-ID: <20170901150317.10380-27-ehabkost@redhat.com> (raw)
In-Reply-To: <20170901150317.10380-1-ehabkost@redhat.com>
From: Igor Mammedov <imammedo@redhat.com>
it's just a wrapper, drop it and use cpu_generic_init() directly
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <1503592308-93913-23-git-send-email-imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/moxie/cpu.h | 3 +--
hw/moxie/moxiesim.c | 2 +-
target/moxie/cpu.c | 5 -----
3 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/target/moxie/cpu.h b/target/moxie/cpu.h
index 8991aaef9a..75decaadd6 100644
--- a/target/moxie/cpu.h
+++ b/target/moxie/cpu.h
@@ -112,7 +112,6 @@ static inline MoxieCPU *moxie_env_get_cpu(CPUMoxieState *env)
#define ENV_OFFSET offsetof(MoxieCPU, env)
-MoxieCPU *cpu_moxie_init(const char *cpu_model);
void moxie_cpu_do_interrupt(CPUState *cs);
void moxie_cpu_dump_state(CPUState *cpu, FILE *f,
fprintf_function cpu_fprintf, int flags);
@@ -121,7 +120,7 @@ void moxie_translate_init(void);
int cpu_moxie_signal_handler(int host_signum, void *pinfo,
void *puc);
-#define cpu_init(cpu_model) CPU(cpu_moxie_init(cpu_model))
+#define cpu_init(cpu_model) cpu_generic_init(TYPE_MOXIE_CPU, cpu_model)
#define cpu_signal_handler cpu_moxie_signal_handler
diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesim.c
index df3f1249ae..4c27b45c46 100644
--- a/hw/moxie/moxiesim.c
+++ b/hw/moxie/moxiesim.c
@@ -118,7 +118,7 @@ static void moxiesim_init(MachineState *machine)
if (cpu_model == NULL) {
cpu_model = "MoxieLite-moxie-cpu";
}
- cpu = cpu_moxie_init(cpu_model);
+ cpu = MOXIE_CPU(cpu_generic_init(TYPE_MOXIE_CPU, cpu_model));
if (!cpu) {
fprintf(stderr, "Unable to find CPU definition\n");
exit(1);
diff --git a/target/moxie/cpu.c b/target/moxie/cpu.c
index 927b1a1e44..748d02f29e 100644
--- a/target/moxie/cpu.c
+++ b/target/moxie/cpu.c
@@ -150,11 +150,6 @@ static const MoxieCPUInfo moxie_cpus[] = {
{ .name = "any", .initfn = moxie_any_initfn },
};
-MoxieCPU *cpu_moxie_init(const char *cpu_model)
-{
- return MOXIE_CPU(cpu_generic_init(TYPE_MOXIE_CPU, cpu_model));
-}
-
static void cpu_register(const MoxieCPUInfo *info)
{
TypeInfo type_info = {
--
2.13.5
next prev parent reply other threads:[~2017-09-01 15:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 15:02 [Qemu-devel] [PULL 00/29] x86 & cpu queue, 2017-09-01 Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 01/29] qom: Remove unused errp parameter from can_be_deleted() Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 02/29] cpu: cpu_by_arch_id() helper Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 03/29] hmp: allow apic-id for "info lapic" Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 04/29] target-i386/cpu: Add new EPYC CPU model Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 05/29] qom: cpu: fix parsed feature string length Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 06/29] sparc: convert cpu models to SPARC cpu subclasses Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 07/29] sparc: embed sparc_def_t into CPUSPARCState Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 08/29] sparc: convert cpu features to qdev properties Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 09/29] sparc: move adhoc CPUSPARCState initialization to realize time Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 10/29] sparc: make cpu feature parsing property based Eduardo Habkost
2017-09-01 15:02 ` [Qemu-devel] [PULL 11/29] sparc: replace cpu_sparc_init() with cpu_generic_init() Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 12/29] s390x: replace cpu_s390x_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 13/29] alpha: replace cpu_alpha_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 14/29] hppa: replace cpu_hppa_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 15/29] m68k: replace cpu_m68k_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 16/29] microblaze: replace cpu_mb_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 17/29] nios2: replace cpu_nios2_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 18/29] tilegx: replace cpu_tilegx_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 19/29] xtensa: replace cpu_xtensa_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 20/29] tricore: replace cpu_tricore_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 21/29] sh4: replace cpu_sh4_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 22/29] arm: replace cpu_arm_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 23/29] cris: replace cpu_cris_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 24/29] x86: replace cpu_x86_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 25/29] lm32: replace cpu_lm32_init() " Eduardo Habkost
2017-09-01 15:03 ` Eduardo Habkost [this message]
2017-09-01 15:03 ` [Qemu-devel] [PULL 27/29] openrisc: replace cpu_openrisc_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 28/29] unicore32: replace uc32_cpu_init() " Eduardo Habkost
2017-09-01 15:03 ` [Qemu-devel] [PULL 29/29] ppc: replace cpu_ppc_init() " Eduardo Habkost
2017-09-04 8:41 ` [Qemu-devel] [PULL 00/29] x86 & cpu queue, 2017-09-01 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901150317.10380-27-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).