From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dosmc-0008WA-PN for qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:56:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doslf-0003YS-QD for qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:55:26 -0400 Date: Mon, 4 Sep 2017 15:48:12 +0100 From: "Daniel P. Berrange" Message-ID: <20170904144812.GD27285@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170904111616.21333-1-kchamart@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170904111616.21333-1-kchamart@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy Cc: qemu-devel@nongnu.org, kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, dgilbert@redhat.com, stefanha@redhat.com On Mon, Sep 04, 2017 at 01:16:16PM +0200, Kashyap Chamarthy wrote: > The test 192 ("Test NBD export with '-incoming' (non-shared > storage migration use case from libvirt")) is currently using HMP. > Replace the HMP usage with QMP, as the upstream preference seems to be: > "Use QMP where possible, unless you're explicitly testing something > related to HMP". > > While at it, convert the test from Bash to Python. FYI This looks like it'll clash with the patch I sent to fix this test case with LUKS https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg00041.html Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|