From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dp4BB-0003SD-VA for qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:05:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dp4B6-00016M-S9 for qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:05:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33436) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dp4B6-00015c-Lt for qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:05:28 -0400 Date: Tue, 5 Sep 2017 11:05:23 +0800 From: Fam Zheng Message-ID: <20170905030523.GI22515@lemon.lan> References: <20170901112829.2571-1-apahim@redhat.com> <20170901112829.2571-6-apahim@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170901112829.2571-6-apahim@redhat.com> Subject: Re: [Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amador Pahim Cc: qemu-devel@nongnu.org, stefanha@gmail.com, berrange@redhat.com, ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com, armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com On Fri, 09/01 13:28, Amador Pahim wrote: > When launching a VM, if an exception happens and the VM is not > initiated, it might be useful to see the qemu command line and > the qemu command output. > > This patch creates that message. Notice that self._iolog needs to be > cleaned up in the beginning of the launch() to make sure we will not > expose the qemu log from a previous launch if the current one fails. > > Signed-off-by: Amador Pahim > --- > scripts/qemu.py | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 670c048569..3ebe5ee0a4 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -141,6 +141,7 @@ class QEMUMachine(object): > > def launch(self): > '''Launch the VM and establish a QMP connection''' > + self._iolog = None > self._qemu_full_args = None > devnull = open(os.path.devnull, 'rb') > qemulog = open(self._qemu_log_path, 'wb') > @@ -160,6 +161,12 @@ class QEMUMachine(object): > self._popen.wait() > self._load_io_log() > self._post_shutdown() > + > + LOG.debug('Error launching VM') > + if self._qemu_full_args: > + LOG.debug('Command: %r', ' '.join(self._qemu_full_args)) > + if self._iolog: > + LOG.debug('Output: %r', self._iolog) > raise > > def shutdown(self): > -- > 2.13.5 > It would be nice if these messages are added to the exception obj, but it's already an improvement over what we have now, so: Reviewed-by: Fam Zheng