From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpAAc-00076t-K8 for qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:29:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpAAY-0007CM-0h for qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:29:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38296) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpAAX-0007Bw-RM for qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:29:17 -0400 From: "Daniel P. Berrange" Date: Tue, 5 Sep 2017 10:29:10 +0100 Message-Id: <20170905092910.8946-3-berrange@redhat.com> In-Reply-To: <20170905092910.8946-1-berrange@redhat.com> References: <20170905092910.8946-1-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 2/2] crypto: fix test cert generation to not use SHA1 algorithm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , "Daniel P. Berrange" GNUTLS 3.6.0 marked SHA1 as untrusted for certificates. Unfortunately the gnutls_x509_crt_sign() method we are using to create certificates in the test suite is fixed to always use SHA1. We must switch to a different method and explicitly ask for SHA256. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- tests/crypto-tls-x509-helpers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/crypto-tls-x509-helpers.c b/tests/crypto-tls-x509-helpers.c index 64073d3bd3..173d4e28fb 100644 --- a/tests/crypto-tls-x509-helpers.c +++ b/tests/crypto-tls-x509-helpers.c @@ -406,7 +406,8 @@ test_tls_generate_cert(QCryptoTLSTestCertReq *req, * If no 'ca' is set then we are self signing * the cert. This is done for the root CA certs */ - err = gnutls_x509_crt_sign(crt, ca ? ca : crt, privkey); + err = gnutls_x509_crt_sign2(crt, ca ? ca : crt, privkey, + GNUTLS_DIG_SHA256, 0); if (err < 0) { g_critical("Failed to sign certificate %s", gnutls_strerror(err)); -- 2.13.5