From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpAoC-0005Cl-An for qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:10:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpAo7-0000uF-3H for qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:10:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpAo6-0000sm-QE for qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:10:11 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D748A80468 for ; Tue, 5 Sep 2017 10:10:09 +0000 (UTC) Date: Tue, 5 Sep 2017 11:10:03 +0100 From: "Daniel P. Berrange" Message-ID: <20170905101003.GD311@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170901180340.30009-1-eblake@redhat.com> <20170901180340.30009-3-eblake@redhat.com> <09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com> <874lshzd2l.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <874lshzd2l.fsf@dusky.pond.sub.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Thomas Huth , pbonzini@redhat.com, qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau On Tue, Sep 05, 2017 at 11:53:22AM +0200, Markus Armbruster wrote: > Thomas Huth writes: >=20 > > On 01.09.2017 20:03, Eric Blake wrote: > >> It doesn't matter if things are unsorted, but finding stuff in a lis= t > >> is easier when it is sorted. (Sorted under LC_ALL=3DC rules, rather= than > >> en_US.UTF-8). > >>=20 > >> Signed-off-by: Eric Blake > >> --- > >> tests/.gitignore | 30 +++++++++++++++--------------- > >> 1 file changed, 15 insertions(+), 15 deletions(-) > > > > Reviewed-by: Thomas Huth > > > > BTW, did you note the patch "build-sys: generate tests/.gitignore" fr= om > > Marc-Andr=C3=A9 ? Maybe the list can be generated automatically, too.= .. > > > >> diff --git a/tests/.gitignore b/tests/.gitignore > >> index 64ecd6683b..8d35a58751 100644 > >> --- a/tests/.gitignore > >> +++ b/tests/.gitignore > >> @@ -1,25 +1,27 @@ > >> +*-test > > > > ... but looking at this wildcard, I wonder if we just named most of o= ur > > tests in a bad way. If we name the files something-test instead of > > test-something, we maybe do not need the automatic generation from > > Marc-Andr=C3=A9 (which is kind of ugly because it writes to the sourc= e > > directory - and this should not happen when doing out of tree builds)= . > > > > So what do you think about renaming our tests, so that the above > > wildcard applies instead? >=20 > Apropos naming tests: there's an (unspoken) convention to name unit > tests check-FOO or test-FOO and tests using libqtest FOO-test, but it's > not really honored anymore, probably because people creating tests > didn't know about it. $ ls *test.c | wc -l 67 $ ls test*.c | wc -l 73 $ ls check*.c | wc -l 8 Fairly even split between 'test' as a prefix vs suffix. 'check' as a prefix should clearly be killed as a minority pattern. Any appetite for standardizing naming of everything else ? A further idea might be to actually have separate sub-directories for unit tests vs qtests. eg go for tests +- unit +- qtest +- iotests Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|