qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.vnet.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
	Pierre Morel <pmorel@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, Halil Pasic <pasic@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 2/5] s390x/css: use ccw data stream
Date: Tue,  5 Sep 2017 13:16:42 +0200	[thread overview]
Message-ID: <20170905111645.18068-3-pasic@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170905111645.18068-1-pasic@linux.vnet.ibm.com>

Replace direct access which implicitly assumes no IDA
or MIDA with the new ccw data stream interface which should
cope with these transparently in the future.

Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
---
 hw/s390x/css.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 87d913f81c..c1bc9944e6 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -890,6 +890,7 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr,
     }
 
     /* Look at the command. */
+    ccw_dstream_init(&sch->cds, &ccw, &(sch->orb));
     switch (ccw.cmd_code) {
     case CCW_CMD_NOOP:
         /* Nothing to do. */
@@ -903,7 +904,7 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr,
             }
         }
         len = MIN(ccw.count, sizeof(sch->sense_data));
-        cpu_physical_memory_write(ccw.cda, sch->sense_data, len);
+        ccw_dstream_write_buf(&sch->cds, sch->sense_data, len);
         sch->curr_status.scsw.count = ccw.count - len;
         memset(sch->sense_data, 0, sizeof(sch->sense_data));
         ret = 0;
@@ -930,7 +931,7 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr,
         } else {
             sense_id.reserved = 0;
         }
-        cpu_physical_memory_write(ccw.cda, &sense_id, len);
+        ccw_dstream_write_buf(&sch->cds, &sense_id, len);
         sch->curr_status.scsw.count = ccw.count - len;
         ret = 0;
         break;
-- 
2.13.5

  parent reply	other threads:[~2017-09-05 11:17 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 11:16 [Qemu-devel] [PATCH 0/5] add CCW indirect data access support Halil Pasic
2017-09-05 11:16 ` [Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream Halil Pasic
2017-09-06 12:18   ` Cornelia Huck
2017-09-06 12:40     ` Halil Pasic
2017-09-06 12:51       ` Cornelia Huck
2017-09-11 16:36         ` Halil Pasic
2017-09-13  9:53           ` Cornelia Huck
2017-09-13 11:35             ` Halil Pasic
2017-09-05 11:16 ` Halil Pasic [this message]
2017-09-06 12:32   ` [Qemu-devel] [PATCH 2/5] s390x/css: use ccw " Cornelia Huck
2017-09-06 12:42     ` Halil Pasic
2017-09-21  9:33   ` Pierre Morel
2017-09-21  9:36     ` Pierre Morel
2017-09-21  9:45     ` Cornelia Huck
2017-09-05 11:16 ` [Qemu-devel] [PATCH 3/5] virtio-ccw: " Halil Pasic
2017-09-06 12:42   ` Cornelia Huck
2017-09-06 12:49     ` Halil Pasic
2017-09-06 12:54       ` Cornelia Huck
2017-09-11 18:14     ` Halil Pasic
2017-09-13  9:58       ` Cornelia Huck
2017-09-13 11:36         ` Halil Pasic
2017-09-05 11:16 ` [Qemu-devel] [PATCH 4/5] s390x/css: support ccw IDA Halil Pasic
2017-09-06 13:10   ` Cornelia Huck
2017-09-11 18:08     ` Halil Pasic
2017-09-13  9:58       ` Cornelia Huck
2017-09-13 10:31         ` Halil Pasic
2017-09-13 10:50           ` Cornelia Huck
2017-09-05 11:16 ` [Qemu-devel] [PATCH 5/5] s390x/ccs: add ccw-tester emulated device Halil Pasic
2017-09-06 13:18   ` Cornelia Huck
2017-09-06 14:24     ` Halil Pasic
2017-09-06 15:20       ` Cornelia Huck
2017-09-06 16:16         ` Halil Pasic
2017-09-07  8:06           ` Cornelia Huck
2017-09-07  9:10             ` Janosch Frank
2017-09-07 12:24               ` Cornelia Huck
2017-09-07  7:31     ` Dong Jia Shi
2017-09-07  8:08       ` Cornelia Huck
2017-09-07 10:21         ` Halil Pasic
2017-09-07 10:52           ` Cornelia Huck
2017-09-08  2:01             ` Dong Jia Shi
2017-09-08 10:28               ` Halil Pasic
2017-09-19  6:03                 ` Dong Jia Shi
2017-09-21  8:45         ` Dong Jia Shi
2017-09-21  8:54           ` Cornelia Huck
2017-09-26  7:48             ` Dong Jia Shi
2017-09-27  7:11               ` Dong Jia Shi
2017-09-08 10:45 ` [Qemu-devel] [PATCH 0/5] add CCW indirect data access support Halil Pasic
2017-09-08 10:49   ` Cornelia Huck
2017-09-08 11:03     ` Halil Pasic
2017-09-08 11:19       ` Cornelia Huck
2017-09-08 11:43         ` Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905111645.18068-3-pasic@linux.vnet.ibm.com \
    --to=pasic@linux.vnet.ibm.com \
    --cc=bjsdjshi@linux.vnet.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).