From: P J P <ppandit@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Guoxiang Niu <niuguoxiang@huawei.com>,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: [Qemu-devel] [PATCH] intc: arm_gicv3: limit GICR ipriority index
Date: Tue, 5 Sep 2017 16:51:52 +0530 [thread overview]
Message-ID: <20170905112152.8851-1-ppandit@redhat.com> (raw)
From: Prasad J Pandit <pjp@fedoraproject.org>
When reading or writing to GICR ipriority array, index 'irq'
could go beyond its bounds; Restrict it within array limits.
Reported-by: Guoxiang Niu <niuguoxiang@huawei.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/intc/arm_gicv3_redist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c
index 77e5cfa327..7683c4cc7f 100644
--- a/hw/intc/arm_gicv3_redist.c
+++ b/hw/intc/arm_gicv3_redist.c
@@ -187,7 +187,7 @@ static MemTxResult gicr_readl(GICv3CPUState *cs, hwaddr offset,
case GICR_ICACTIVER0:
*data = gicr_read_bitmap_reg(cs, attrs, cs->gicr_iactiver0);
return MEMTX_OK;
- case GICR_IPRIORITYR ... GICR_IPRIORITYR + 0x1f:
+ case GICR_IPRIORITYR ... GICR_IPRIORITYR + 0x1c:
{
int i, irq = offset - GICR_IPRIORITYR;
uint32_t value = 0;
@@ -310,7 +310,7 @@ static MemTxResult gicr_writel(GICv3CPUState *cs, hwaddr offset,
case GICR_ICACTIVER0:
gicr_write_clear_bitmap_reg(cs, attrs, &cs->gicr_iactiver0, value);
return MEMTX_OK;
- case GICR_IPRIORITYR ... GICR_IPRIORITYR + 0x1f:
+ case GICR_IPRIORITYR ... GICR_IPRIORITYR + 0x1c:
{
int i, irq = offset - GICR_IPRIORITYR;
--
2.13.5
next reply other threads:[~2017-09-05 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 11:21 P J P [this message]
2017-09-05 11:58 ` [Qemu-devel] [PATCH] intc: arm_gicv3: limit GICR ipriority index Peter Maydell
2017-09-05 12:29 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-09-05 12:30 ` [Qemu-devel] 答复: " niuguoxiang
2017-09-05 12:35 ` Peter Maydell
2017-09-05 19:42 ` Eric Blake
2017-09-06 6:45 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905112152.8851-1-ppandit@redhat.com \
--to=ppandit@redhat.com \
--cc=niuguoxiang@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).