From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PATCH v6 1/6] armv7m: Convert bitband.source-memory to DEFINE_PROP_LINK
Date: Tue, 5 Sep 2017 21:11:44 +0800 [thread overview]
Message-ID: <20170905131149.10669-2-famz@redhat.com> (raw)
In-Reply-To: <20170905131149.10669-1-famz@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/arm/armv7m.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c
index d2477e84e4..4c560dde56 100644
--- a/hw/arm/armv7m.c
+++ b/hw/arm/armv7m.c
@@ -97,12 +97,6 @@ static void bitband_init(Object *obj)
BitBandState *s = BITBAND(obj);
SysBusDevice *dev = SYS_BUS_DEVICE(obj);
- object_property_add_link(obj, "source-memory",
- TYPE_MEMORY_REGION,
- (Object **)&s->source_memory,
- qdev_prop_allow_set_link_before_realize,
- OBJ_PROP_LINK_UNREF_ON_RELEASE,
- &error_abort);
memory_region_init_io(&s->iomem, obj, &bitband_ops, s,
"bitband", 0x02000000);
sysbus_init_mmio(dev, &s->iomem);
@@ -349,6 +343,8 @@ void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int mem_size)
static Property bitband_properties[] = {
DEFINE_PROP_UINT32("base", BitBandState, base, 0),
+ DEFINE_PROP_LINK("source-memory", BitBandState, source_memory,
+ TYPE_MEMORY_REGION, MemoryRegion *),
DEFINE_PROP_END_OF_LIST(),
};
--
2.13.5
next prev parent reply other threads:[~2017-09-05 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 13:11 [Qemu-devel] [PATCH v6 0/6] arm: Make use of DEFINE_PROP_LINK Fam Zheng
2017-09-05 13:11 ` Fam Zheng [this message]
2017-09-05 13:11 ` [Qemu-devel] [PATCH v6 2/6] armv7m: Convert armv7m.memory to DEFINE_PROP_LINK Fam Zheng
2017-09-05 13:11 ` [Qemu-devel] [PATCH v6 3/6] gicv3: Convert " Fam Zheng
2017-09-05 13:44 ` Philippe Mathieu-Daudé
2017-09-05 15:35 ` Fam Zheng
2017-09-05 16:20 ` Philippe Mathieu-Daudé
2017-09-05 13:11 ` [Qemu-devel] [PATCH v6 4/6] xlnx_zynqmp: " Fam Zheng
2017-09-05 13:11 ` [Qemu-devel] [PATCH v6 5/6] xilinx_axienet: " Fam Zheng
2017-09-05 13:11 ` [Qemu-devel] [PATCH v6 6/6] xilinx_axidma: " Fam Zheng
2017-09-05 15:47 ` [Qemu-devel] [PATCH v6 0/6] arm: Make use of DEFINE_PROP_LINK Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905131149.10669-2-famz@redhat.com \
--to=famz@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).