From: Stefan Hajnoczi <stefanha@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-block <qemu-block@nongnu.org>,
Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 5/6] block: add throttle block filter driver
Date: Tue, 5 Sep 2017 14:58:41 +0100 [thread overview]
Message-ID: <20170905135841.GP17449@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170825132028.6184-6-el13635@mail.ntua.gr>
On Fri, Aug 25, 2017 at 04:20:27PM +0300, Manos Pitsidianakis wrote:
> +static int throttle_configure_tgm(BlockDriverState *bs,
> + ThrottleGroupMember *tgm,
> + QDict *options, Error **errp)
> +{
> + int ret;
> + const char *group_name;
> + Error *local_err = NULL;
> + QemuOpts *opts = qemu_opts_create(&throttle_opts, NULL, 0, &error_abort);
> +
> + qemu_opts_absorb_qdict(opts, options, &local_err);
> + if (local_err) {
> + error_propagate(errp, local_err);
> + ret = -EINVAL;
> + goto fin;
> + }
> +
> + group_name = qemu_opt_get(opts, QEMU_OPT_THROTTLE_GROUP_NAME);
> + if (!group_name) {
> + error_setg(errp, "Please specify a throttle group.");
error_setg() messages do not end with punctuation:
error_setg(errp, "Please specify a throttle group");
This is not worth respinning for though.
> + ret = -EINVAL;
> + goto fin;
> + } else if (!throttle_group_exists(group_name)) {
> + error_setg(errp, "Throttle group '%s' does not exist.", group_name);
Same here.
Anyway:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2017-09-05 13:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 13:20 [Qemu-devel] [PATCH v9 0/6] add throttle block driver filter Manos Pitsidianakis
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 1/6] block: move ThrottleGroup membership to ThrottleGroupMember Manos Pitsidianakis
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 2/6] block: add aio_context field in ThrottleGroupMember Manos Pitsidianakis
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 3/6] block: tidy ThrottleGroupMember initializations Manos Pitsidianakis
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 4/6] block: convert ThrottleGroup to object with QOM Manos Pitsidianakis
2017-08-28 9:52 ` Alberto Garcia
2017-09-05 13:49 ` Stefan Hajnoczi
2017-09-05 15:21 ` Kevin Wolf
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 5/6] block: add throttle block filter driver Manos Pitsidianakis
2017-09-05 13:58 ` Stefan Hajnoczi [this message]
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 6/6] qemu-iotests: add 184 for throttle " Manos Pitsidianakis
2017-09-05 14:01 ` Stefan Hajnoczi
2017-09-05 16:16 ` Kevin Wolf
2017-09-05 19:06 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-09-05 21:13 ` Eric Blake
2017-09-06 8:26 ` Manos Pitsidianakis
2017-09-06 8:32 ` Kevin Wolf
2017-09-05 14:01 ` [Qemu-devel] [PATCH v9 0/6] add throttle block driver filter Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905135841.GP17449@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).