From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpD7T-0003Rc-Lo for qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:38:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpD7K-0007F3-4F for qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:38:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47682) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpD7J-0007Eo-UE for qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:38:10 -0400 Date: Tue, 5 Sep 2017 14:38:01 +0200 From: Cornelia Huck Message-ID: <20170905143801.1dc39cb1.cohuck@redhat.com> In-Reply-To: <20170904154316.4148-9-david@redhat.com> References: <20170904154316.4148-1-david@redhat.com> <20170904154316.4148-9-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-devel@nongnu.org, Richard Henderson , thuth@redhat.com, borntraeger@de.ibm.com, Alexander Graf , Eduardo Habkost On Mon, 4 Sep 2017 17:43:05 +0200 David Hildenbrand wrote: > Fix up includes and rename it to s390x_*. I'm not quite sure whether that is the right direction: servc is just an instruction that does something and then happens to also generate an interrupt on conclusion. I'll think a bit more about it. > cpu.h is now free of externally implemented functions. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/sclp.c | 51 +--------------------------------------------- > include/hw/s390x/sclp.h | 1 + > target/s390x/cpu.h | 5 +---- > target/s390x/interrupt.c | 49 ++++++++++++++++++++++++++++++++++++++++++++ > target/s390x/kvm.c | 2 +- > target/s390x/misc_helper.c | 2 +- > 6 files changed, 54 insertions(+), 56 deletions(-)