From: Kevin Wolf <kwolf@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v9 6/6] qemu-iotests: add 184 for throttle filter driver
Date: Tue, 5 Sep 2017 21:06:21 +0200 [thread overview]
Message-ID: <20170905190621.GQ4633@localhost.localdomain> (raw)
In-Reply-To: <20170905161643.GO4633@localhost.localdomain>
Am 05.09.2017 um 18:16 hat Kevin Wolf geschrieben:
> Am 25.08.2017 um 15:20 hat Manos Pitsidianakis geschrieben:
> > Reviewed-by: Alberto Garcia <berto@igalia.com>
> > Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
>
> Does this test actually (still) pass for you? I can't see that it's
> related to any recent change in master, but this is the diff that I get.
>
> I can update the reference output while applying, but obviously if it's
> currently passing for you, it will fail after I "fix" it.
For the record, we discussed this on IRC. The test works correctly on
master, but on my block branch there is a conflict with "block: pass
bdrv_* methods to bs->file by default in block filters".
The correct action is to merge this throttle driver series after the
conflicting patch because throttle doesn't implement .bdrv_get_info and
needs the forwarding that the other patch implements.
I updated the test output accordingly and applied the series to my block
branch.
Kevin
next prev parent reply other threads:[~2017-09-05 19:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 13:20 [Qemu-devel] [PATCH v9 0/6] add throttle block driver filter Manos Pitsidianakis
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 1/6] block: move ThrottleGroup membership to ThrottleGroupMember Manos Pitsidianakis
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 2/6] block: add aio_context field in ThrottleGroupMember Manos Pitsidianakis
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 3/6] block: tidy ThrottleGroupMember initializations Manos Pitsidianakis
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 4/6] block: convert ThrottleGroup to object with QOM Manos Pitsidianakis
2017-08-28 9:52 ` Alberto Garcia
2017-09-05 13:49 ` Stefan Hajnoczi
2017-09-05 15:21 ` Kevin Wolf
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 5/6] block: add throttle block filter driver Manos Pitsidianakis
2017-09-05 13:58 ` Stefan Hajnoczi
2017-08-25 13:20 ` [Qemu-devel] [PATCH v9 6/6] qemu-iotests: add 184 for throttle " Manos Pitsidianakis
2017-09-05 14:01 ` Stefan Hajnoczi
2017-09-05 16:16 ` Kevin Wolf
2017-09-05 19:06 ` Kevin Wolf [this message]
2017-09-05 21:13 ` [Qemu-devel] [Qemu-block] " Eric Blake
2017-09-06 8:26 ` Manos Pitsidianakis
2017-09-06 8:32 ` Kevin Wolf
2017-09-05 14:01 ` [Qemu-devel] [PATCH v9 0/6] add throttle block driver filter Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905190621.GQ4633@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).