qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 0/3] nbd: Use common read/write-all qio functions
Date: Tue,  5 Sep 2017 14:11:11 -0500	[thread overview]
Message-ID: <20170905191114.5959-1-eblake@redhat.com> (raw)

Now that Daniel just added convenience qio channel looping functions,
we might as well use it in NBD instead of open-coding our own.  In
doing so, fix a couple of short-falls noticed in the qio code.

If Dan is happy with this, I can take the series through the NBD queue.

[The diffstat is slightly misleading - it's a net reduction in lines
of code, but the added comments hide that fact]

Eric Blake (3):
  io: Yield rather than wait when already in coroutine
  io: Add new qio_channel_read{,v}_all_eof functions
  nbd: Use new qio_channel_*_all() functions

 include/block/nbd.h        |  2 --
 include/io/channel.h       | 53 ++++++++++++++++++++++++++++++++++++++++
 nbd/nbd-internal.h         | 41 ++++++-------------------------
 block/nbd-client.c         | 15 ++++++------
 io/channel.c               | 60 ++++++++++++++++++++++++++++++++++++++--------
 nbd/common.c               | 45 ----------------------------------
 tests/qemu-iotests/083.out |  8 +++----
 7 files changed, 121 insertions(+), 103 deletions(-)

-- 
2.13.5

             reply	other threads:[~2017-09-05 19:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 19:11 Eric Blake [this message]
2017-09-05 19:11 ` [Qemu-devel] [PATCH 1/3] io: Yield rather than wait when already in coroutine Eric Blake
2017-09-06  8:50   ` Daniel P. Berrange
2017-09-06 14:53     ` Paolo Bonzini
2017-09-06 15:16     ` Eric Blake
2017-09-05 19:11 ` [Qemu-devel] [PATCH 2/3] io: Add new qio_channel_read{, v}_all_eof functions Eric Blake
2017-09-06  8:51   ` Daniel P. Berrange
2017-09-05 19:11 ` [Qemu-devel] [PATCH 3/3] nbd: Use new qio_channel_*_all() functions Eric Blake
2017-09-06  8:52   ` Daniel P. Berrange
2017-09-06 15:14 ` [Qemu-devel] [PATCH 0/3] nbd: Use common read/write-all qio functions Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905191114.5959-1-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).