From: Kevin Wolf <kwolf@redhat.com>
To: Pavel Butsykin <pbutsykin@virtuozzo.com>
Cc: Eric Blake <eblake@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org, den@openvz.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qcow2: move qcow2_store_persistent_dirty_bitmaps() before cache flushing
Date: Wed, 6 Sep 2017 14:40:50 +0200 [thread overview]
Message-ID: <20170906124050.GG3753@dhcp-200-186.str.redhat.com> (raw)
In-Reply-To: <ad95bfe5-22e1-6d62-4fe2-a2e8cfd9c82b@virtuozzo.com>
Am 06.09.2017 um 10:19 hat Pavel Butsykin geschrieben:
> On 05.09.2017 22:30, Eric Blake wrote:
> > On 09/04/2017 05:18 AM, Pavel Butsykin wrote:
> > > After calling qcow2_inactivate(), all qcow2 caches must be flushed, but this
> > > may not happen, because the last call qcow2_store_persistent_dirty_bitmaps()
> > > can lead to marking l2/refcont cache as dirty.
> > >
> > > Let's move qcow2_store_persistent_dirty_bitmaps() before the caсhe flushing
> > > to fix it.
> > >
> > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
> > > ---
> > > block/qcow2.c | 16 ++++++++--------
> > > 1 file changed, 8 insertions(+), 8 deletions(-)
> > >
> >
> > Should this cc: qemu-stable?
>
> The latest stable branch (2.8?) doesn't contain the persistent dirty bitmap.
Cc: qemu-stable would now be for qemu 2.10.1, which I think does need
the fix. I'm adding the tag.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2017-09-06 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 10:18 [Qemu-devel] [PATCH] qcow2: move qcow2_store_persistent_dirty_bitmaps() before cache flushing Pavel Butsykin
2017-09-05 19:30 ` Eric Blake
2017-09-06 8:19 ` Pavel Butsykin
2017-09-06 12:40 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906124050.GG3753@dhcp-200-186.str.redhat.com \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbutsykin@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).