From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Sergio Andrés Gómez del Real" <sergio.g.delreal@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 08/14] hvf: add compilation rules to Makefile.objs
Date: Wed, 6 Sep 2017 14:57:08 +0100 [thread overview]
Message-ID: <20170906135708.GD15535@stefanha-x1.localdomain> (raw)
In-Reply-To: <CAMzKsXu0LOR=mzBNq-=sbv3YRBCjKXxx2NjeJya-TPkK6mYT2Q@mail.gmail.com>
On Tue, Sep 05, 2017 at 08:12:31PM -0500, Sergio Andrés Gómez del Real wrote:
> Stefan, is this acceptable? I mean delaying the compiling; up until patch 7
> no hvf code is compiled. Or should I just squash everything from patch 2 to
> 7?
It's okay. Feel free to delay until patch 7 for now.
There is value in importing code verbatim and making changes in separate
patches. That way it's easy to diff the code against the upstream
source to verify that it was imported correctly.
Stefan
next prev parent reply other threads:[~2017-09-06 13:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 3:54 [Qemu-devel] [PATCH v3 00/14] add support for Hypervisor.framework in QEMU Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 01/14] hvf: add support for Hypervisor.framework in the configure script Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 02/14] hvf: add code base from Google's QEMU repository Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 03/14] hvf: fix licensing issues; isolate task handling code (GPL v2-only) Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 04/14] hvf: run hvf code through checkpatch.pl and fix style issues Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 05/14] hvf: add code to cpus.c and do refactoring in preparation for compiling Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 06/14] hvf: handle fields from CPUState and CPUX86State Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 07/14] apic: add function to apic that will be used by hvf Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 08/14] hvf: add compilation rules to Makefile.objs Sergio Andres Gomez Del Real
2017-09-05 4:03 ` Sergio Andrés Gómez del Real
2017-09-06 1:12 ` Sergio Andrés Gómez del Real
2017-09-06 13:57 ` Stefan Hajnoczi [this message]
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 09/14] hvf: use new helper functions for put/get xsave Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 10/14] hvf: implement hvf_get_supported_cpuid Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 11/14] hvf: refactor cpuid code Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 12/14] hvf: implement vga dirty page tracking Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 13/14] hvf: refactor event injection code for hvf Sergio Andres Gomez Del Real
2017-09-05 3:54 ` [Qemu-devel] [PATCH v3 14/14] hvf: inject General Protection Fault when vmexit through vmcall Sergio Andres Gomez Del Real
2017-09-05 3:59 ` [Qemu-devel] [PATCH v3 00/14] add support for Hypervisor.framework in QEMU Sergio Andrés Gómez del Real
2017-09-05 9:24 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906135708.GD15535@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sergio.g.delreal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).