From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 3/9] buildsys: Move vnc cflags/libs to per object
Date: Thu, 7 Sep 2017 16:29:12 +0800 [thread overview]
Message-ID: <20170907082918.7299-4-famz@redhat.com> (raw)
In-Reply-To: <20170907082918.7299-1-famz@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
configure | 14 ++++++++------
ui/Makefile.objs | 21 ++++++++++++---------
2 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/configure b/configure
index 812a1ce615..9b0eb91a9b 100755
--- a/configure
+++ b/configure
@@ -2834,8 +2834,8 @@ EOF
vnc_sasl_libs="-lsasl2"
if compile_prog "$vnc_sasl_cflags" "$vnc_sasl_libs" ; then
vnc_sasl=yes
- libs_softmmu="$vnc_sasl_libs $libs_softmmu"
- QEMU_CFLAGS="$QEMU_CFLAGS $vnc_sasl_cflags"
+ vnc_libs="$vnc_libs $vnc_sasl_libs"
+ vnc_cflags="$vnc_cflags $vnc_sasl_cflags"
else
if test "$vnc_sasl" = "yes" ; then
feature_not_found "vnc-sasl" "Install Cyrus SASL devel"
@@ -2856,8 +2856,8 @@ EOF
vnc_jpeg_libs="-ljpeg"
if compile_prog "$vnc_jpeg_cflags" "$vnc_jpeg_libs" ; then
vnc_jpeg=yes
- libs_softmmu="$vnc_jpeg_libs $libs_softmmu"
- QEMU_CFLAGS="$QEMU_CFLAGS $vnc_jpeg_cflags"
+ vnc_libs="$vnc_libs $vnc_jpeg_libs"
+ vnc_cflags="$vnc_cflags $vnc_jpeg_cflags"
else
if test "$vnc_jpeg" = "yes" ; then
feature_not_found "vnc-jpeg" "Install libjpeg-turbo devel"
@@ -2888,8 +2888,8 @@ EOF
fi
if compile_prog "$vnc_png_cflags" "$vnc_png_libs" ; then
vnc_png=yes
- libs_softmmu="$vnc_png_libs $libs_softmmu"
- QEMU_CFLAGS="$QEMU_CFLAGS $vnc_png_cflags"
+ vnc_libs="$vnc_libs $vnc_png_libs"
+ vnc_cflags="$vnc_cflags $vnc_png_cflags"
else
if test "$vnc_png" = "yes" ; then
feature_not_found "vnc-png" "Install libpng devel"
@@ -5558,6 +5558,8 @@ echo "CONFIG_BDRV_RW_WHITELIST=$block_drv_rw_whitelist" >> $config_host_mak
echo "CONFIG_BDRV_RO_WHITELIST=$block_drv_ro_whitelist" >> $config_host_mak
if test "$vnc" = "yes" ; then
echo "CONFIG_VNC=y" >> $config_host_mak
+ echo "VNC_CFLAGS=$vnc_cflags" >> $config_host_mak
+ echo "VNC_LIBS=$vnc_libs" >> $config_host_mak
fi
if test "$vnc_sasl" = "yes" ; then
echo "CONFIG_VNC_SASL=y" >> $config_host_mak
diff --git a/ui/Makefile.objs b/ui/Makefile.objs
index b3e29e21f0..a0b3c15a28 100644
--- a/ui/Makefile.objs
+++ b/ui/Makefile.objs
@@ -1,11 +1,14 @@
-vnc-obj-y += vnc.o
-vnc-obj-y += vnc-enc-zlib.o vnc-enc-hextile.o
-vnc-obj-y += vnc-enc-tight.o vnc-palette.o
-vnc-obj-y += vnc-enc-zrle.o
-vnc-obj-y += vnc-auth-vencrypt.o
-vnc-obj-$(CONFIG_VNC_SASL) += vnc-auth-sasl.o
-vnc-obj-y += vnc-ws.o
-vnc-obj-y += vnc-jobs.o
+vnc.mo-objs += vnc.o
+vnc.mo-objs += vnc-enc-zlib.o vnc-enc-hextile.o
+vnc.mo-objs += vnc-enc-tight.o vnc-palette.o
+vnc.mo-objs += vnc-enc-zrle.o
+vnc.mo-objs += vnc-auth-vencrypt.o
+vnc.mo-objs += $(if $(CONFIG_VNC_SASL), vnc-auth-sasl.o)
+vnc.mo-objs += vnc-ws.o
+vnc.mo-objs += vnc-jobs.o
+
+vnc.mo-cflags := $(VNC_CFLAGS)
+vnc.mo-libs := $(VNC_LIBS)
common-obj-y += keymaps.o console.o cursor.o qemu-pixman.o
common-obj-y += input.o input-keymap.o input-legacy.o
@@ -14,7 +17,7 @@ common-obj-$(CONFIG_SPICE) += spice-core.o spice-input.o spice-display.o
common-obj-$(CONFIG_SDL) += sdl.mo x_keymap.o
common-obj-$(CONFIG_COCOA) += cocoa.o
common-obj-$(CONFIG_CURSES) += curses.o
-common-obj-$(CONFIG_VNC) += $(vnc-obj-y)
+common-obj-$(CONFIG_VNC) += vnc.mo
common-obj-$(CONFIG_GTK) += gtk.o x_keymap.o
ifeq ($(CONFIG_SDLABI),1.2)
--
2.13.5
next prev parent reply other threads:[~2017-09-07 8:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 8:29 [Qemu-devel] [PATCH 0/9] buildsys: Move ui/usb library cflags/libs to per object Fam Zheng
2017-09-07 8:29 ` [Qemu-devel] [PATCH 1/9] buildsys: Move gtk/vte " Fam Zheng
2017-09-07 17:45 ` Philippe Mathieu-Daudé
2017-09-07 17:50 ` Peter Maydell
2017-09-07 8:29 ` [Qemu-devel] [PATCH 2/9] buildsys: Move sdl " Fam Zheng
2017-09-07 8:29 ` Fam Zheng [this message]
2017-09-07 8:29 ` [Qemu-devel] [PATCH 4/9] buildsys: Move audio libs " Fam Zheng
2017-09-07 8:29 ` [Qemu-devel] [PATCH 5/9] buildsys: Move curese cflags/libs " Fam Zheng
2017-09-07 8:29 ` [Qemu-devel] [PATCH 6/9] buildsys: Move opengl cflags " Fam Zheng
2017-09-07 8:29 ` [Qemu-devel] [PATCH 7/9] buildsys: Move libcacard cflags/libs " Fam Zheng
2017-09-07 17:46 ` Philippe Mathieu-Daudé
2017-09-08 6:12 ` Fam Zheng
2017-09-07 8:29 ` [Qemu-devel] [PATCH 8/9] buildsys: Move libusb " Fam Zheng
2017-09-07 8:29 ` [Qemu-devel] [PATCH 9/9] buildsys: Move usb redir " Fam Zheng
2017-09-07 9:34 ` [Qemu-devel] [PATCH 0/9] buildsys: Move ui/usb library " Gerd Hoffmann
2017-09-07 11:43 ` Fam Zheng
2017-09-07 17:48 ` Philippe Mathieu-Daudé
2017-09-08 6:20 ` Gerd Hoffmann
2017-09-08 6:28 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907082918.7299-4-famz@redhat.com \
--to=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).