qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 6/9] buildsys: Move opengl cflags to per object
Date: Thu,  7 Sep 2017 16:29:15 +0800	[thread overview]
Message-ID: <20170907082918.7299-7-famz@redhat.com> (raw)
In-Reply-To: <20170907082918.7299-1-famz@redhat.com>

Opengl libs are already moved to per object, do so for the cflags as
well.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 configure        | 2 +-
 ui/Makefile.objs | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index b08cb4ce02..b1320b1994 100755
--- a/configure
+++ b/configure
@@ -3623,7 +3623,6 @@ if test "$opengl" != "no" ; then
     if test "$gtk" = "yes" && $pkg_config --exists "$gtkpackage >= 3.16"; then
         gtk_gl="yes"
     fi
-    QEMU_CFLAGS="$QEMU_CFLAGS $opengl_cflags"
   else
     if test "$opengl" = "yes" ; then
       feature_not_found "opengl" "Please install opengl (mesa) devel pkgs: $opengl_pkgs"
@@ -5844,6 +5843,7 @@ fi
 
 if test "$opengl" = "yes" ; then
   echo "CONFIG_OPENGL=y" >> $config_host_mak
+  echo "OPENGL_CFLAGS=$opengl_cflags" >> $config_host_mak
   echo "OPENGL_LIBS=$opengl_libs" >> $config_host_mak
   if test "$opengl_dmabuf" = "yes" ; then
     echo "CONFIG_OPENGL_DMABUF=y" >> $config_host_mak
diff --git a/ui/Makefile.objs b/ui/Makefile.objs
index e3403b698b..95943d9c33 100644
--- a/ui/Makefile.objs
+++ b/ui/Makefile.objs
@@ -53,10 +53,10 @@ gtk.o-libs := $(GTK_LIBS) $(VTE_LIBS)
 gtk-egl.o-libs := $(GTK_LIBS) $(VTE_LIBS)
 gtk-gl-area.o-libs := $(GTK_LIBS) $(VTE_LIBS)
 
-gtk-egl.o-libs += $(OPENGL_LIBS)
-shader.o-libs += $(OPENGL_LIBS)
-console-gl.o-libs += $(OPENGL_LIBS)
-egl-helpers.o-libs += $(OPENGL_LIBS)
+$(foreach x, gtk-egl shader console egl-helpers, \
+	$(eval $x.o-libs += $(OPENGL_LIBS)) \
+	$(eval $x.o-cflags += $(OPENGL_CFLAGS)) \
+)
 
 curses.o-cflags := $(CURSES_CFLAGS)
 curses.o-libs := $(CURSES_LIBS)
-- 
2.13.5

  parent reply	other threads:[~2017-09-07  8:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07  8:29 [Qemu-devel] [PATCH 0/9] buildsys: Move ui/usb library cflags/libs to per object Fam Zheng
2017-09-07  8:29 ` [Qemu-devel] [PATCH 1/9] buildsys: Move gtk/vte " Fam Zheng
2017-09-07 17:45   ` Philippe Mathieu-Daudé
2017-09-07 17:50     ` Peter Maydell
2017-09-07  8:29 ` [Qemu-devel] [PATCH 2/9] buildsys: Move sdl " Fam Zheng
2017-09-07  8:29 ` [Qemu-devel] [PATCH 3/9] buildsys: Move vnc " Fam Zheng
2017-09-07  8:29 ` [Qemu-devel] [PATCH 4/9] buildsys: Move audio libs " Fam Zheng
2017-09-07  8:29 ` [Qemu-devel] [PATCH 5/9] buildsys: Move curese cflags/libs " Fam Zheng
2017-09-07  8:29 ` Fam Zheng [this message]
2017-09-07  8:29 ` [Qemu-devel] [PATCH 7/9] buildsys: Move libcacard " Fam Zheng
2017-09-07 17:46   ` Philippe Mathieu-Daudé
2017-09-08  6:12     ` Fam Zheng
2017-09-07  8:29 ` [Qemu-devel] [PATCH 8/9] buildsys: Move libusb " Fam Zheng
2017-09-07  8:29 ` [Qemu-devel] [PATCH 9/9] buildsys: Move usb redir " Fam Zheng
2017-09-07  9:34 ` [Qemu-devel] [PATCH 0/9] buildsys: Move ui/usb library " Gerd Hoffmann
2017-09-07 11:43   ` Fam Zheng
2017-09-07 17:48     ` Philippe Mathieu-Daudé
2017-09-08  6:20     ` Gerd Hoffmann
2017-09-08  6:28       ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170907082918.7299-7-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).