* [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
@ 2017-09-01 11:03 Eduardo Otubo
2017-09-01 14:30 ` Eduardo Habkost
0 siblings, 1 reply; 11+ messages in thread
From: Eduardo Otubo @ 2017-09-01 11:03 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, mst, pbonzini, ehabkost
When used with the following command line:
./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
QEMU with machine type 40p already creates the device i82374. If
specified in the command line, it will try to create it again, hence
generating the error. One way to avoid this problem is to set
user_creatable=false.
Signed-off-by: Eduardo Otubo <otubo@redhat.com>
---
hw/dma/i82374.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
index 6c0f975df0..5275d822e0 100644
--- a/hw/dma/i82374.c
+++ b/hw/dma/i82374.c
@@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)
dc->realize = i82374_realize;
dc->vmsd = &vmstate_i82374;
dc->props = i82374_properties;
+ dc->user_creatable = false;
}
static const TypeInfo i82374_info = {
--
2.13.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-01 11:03 [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device Eduardo Otubo
@ 2017-09-01 14:30 ` Eduardo Habkost
2017-09-01 15:34 ` Markus Armbruster
2017-09-02 9:15 ` [Qemu-devel] " Aurelien Jarno
0 siblings, 2 replies; 11+ messages in thread
From: Eduardo Habkost @ 2017-09-01 14:30 UTC (permalink / raw)
To: Eduardo Otubo
Cc: qemu-devel, qemu-trivial, mst, pbonzini, David Gibson,
Alexander Graf, qemu-ppc, Aurelien Jarno
i82374 is compiled in only on ppc and sh4, so I'm CCing the
maintainers for those architectures.
On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:
> When used with the following command line:
>
> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
>
> QEMU with machine type 40p already creates the device i82374. If
> specified in the command line, it will try to create it again, hence
> generating the error.
Which error?
> One way to avoid this problem is to set
> user_creatable=false.
>
> Signed-off-by: Eduardo Otubo <otubo@redhat.com>
The patch does more than just avoiding double creation: it
prevents usage of "-device i82374" completely.
Maybe nobody needs it to work with -device today (would the
device even work?) and it is OK to set user_creatable=false until
we fix the crash. But we need to be sure of that.
> ---
> hw/dma/i82374.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
> index 6c0f975df0..5275d822e0 100644
> --- a/hw/dma/i82374.c
> +++ b/hw/dma/i82374.c
> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)
> dc->realize = i82374_realize;
> dc->vmsd = &vmstate_i82374;
> dc->props = i82374_properties;
> + dc->user_creatable = false;
A "Reason:" comment explaining why user_creatable=false is
mandatory. See the comment above user_creatable declaration in
qdev-core.h for reference.
I suggest the following:
/*
* Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()
* if the device is instantiated twice.
*/
--
Eduardo
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-01 14:30 ` Eduardo Habkost
@ 2017-09-01 15:34 ` Markus Armbruster
2017-09-01 15:44 ` Eduardo Habkost
2017-09-02 9:15 ` [Qemu-devel] " Aurelien Jarno
1 sibling, 1 reply; 11+ messages in thread
From: Markus Armbruster @ 2017-09-01 15:34 UTC (permalink / raw)
To: Eduardo Habkost
Cc: Eduardo Otubo, mst, qemu-trivial, Alexander Graf, qemu-devel,
qemu-ppc, pbonzini, Aurelien Jarno, David Gibson
Eduardo Habkost <ehabkost@redhat.com> writes:
> i82374 is compiled in only on ppc and sh4, so I'm CCing the
> maintainers for those architectures.
>
> On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:
>> When used with the following command line:
>>
>> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
>>
>> QEMU with machine type 40p already creates the device i82374. If
>> specified in the command line, it will try to create it again, hence
>> generating the error.
>
> Which error?
>
>
>> One way to avoid this problem is to set
>> user_creatable=false.
>>
>> Signed-off-by: Eduardo Otubo <otubo@redhat.com>
>
> The patch does more than just avoiding double creation: it
> prevents usage of "-device i82374" completely.
>
> Maybe nobody needs it to work with -device today (would the
> device even work?) and it is OK to set user_creatable=false until
> we fix the crash. But we need to be sure of that.
>
>> ---
>> hw/dma/i82374.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
>> index 6c0f975df0..5275d822e0 100644
>> --- a/hw/dma/i82374.c
>> +++ b/hw/dma/i82374.c
>> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)
>> dc->realize = i82374_realize;
>> dc->vmsd = &vmstate_i82374;
>> dc->props = i82374_properties;
>> + dc->user_creatable = false;
>
> A "Reason:" comment explaining why user_creatable=false is
> mandatory. See the comment above user_creatable declaration in
> qdev-core.h for reference.
>
> I suggest the following:
>
> /*
> * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()
> * if the device is instantiated twice.
> */
We need to find out *why* it crashes. Once we know, we can likely write
a better comment.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-01 15:34 ` Markus Armbruster
@ 2017-09-01 15:44 ` Eduardo Habkost
2017-09-07 8:38 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
0 siblings, 1 reply; 11+ messages in thread
From: Eduardo Habkost @ 2017-09-01 15:44 UTC (permalink / raw)
To: Markus Armbruster
Cc: Eduardo Otubo, mst, qemu-trivial, Alexander Graf, qemu-devel,
qemu-ppc, pbonzini, Aurelien Jarno, David Gibson
On Fri, Sep 01, 2017 at 05:34:34PM +0200, Markus Armbruster wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
>
> > i82374 is compiled in only on ppc and sh4, so I'm CCing the
> > maintainers for those architectures.
> >
> > On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:
> >> When used with the following command line:
> >>
> >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
> >>
> >> QEMU with machine type 40p already creates the device i82374. If
> >> specified in the command line, it will try to create it again, hence
> >> generating the error.
> >
> > Which error?
> >
> >
> >> One way to avoid this problem is to set
> >> user_creatable=false.
> >>
> >> Signed-off-by: Eduardo Otubo <otubo@redhat.com>
> >
> > The patch does more than just avoiding double creation: it
> > prevents usage of "-device i82374" completely.
> >
> > Maybe nobody needs it to work with -device today (would the
> > device even work?) and it is OK to set user_creatable=false until
> > we fix the crash. But we need to be sure of that.
> >
> >> ---
> >> hw/dma/i82374.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
> >> index 6c0f975df0..5275d822e0 100644
> >> --- a/hw/dma/i82374.c
> >> +++ b/hw/dma/i82374.c
> >> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)
> >> dc->realize = i82374_realize;
> >> dc->vmsd = &vmstate_i82374;
> >> dc->props = i82374_properties;
> >> + dc->user_creatable = false;
> >
> > A "Reason:" comment explaining why user_creatable=false is
> > mandatory. See the comment above user_creatable declaration in
> > qdev-core.h for reference.
> >
> > I suggest the following:
> >
> > /*
> > * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()
> > * if the device is instantiated twice.
> > */
>
> We need to find out *why* it crashes. Once we know, we can likely write
> a better comment.
It crashes because isa_bus_dma() isn't supposed to be called
twice for the same bus.
Making isa_bus_dma()/DMA_init()/i82374_realize() return an error
instead of asserting would be even better than setting
user_creatable=false.
--
Eduardo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-01 15:44 ` Eduardo Habkost
@ 2017-09-07 8:38 ` Eduardo Otubo
2017-09-09 21:52 ` Eduardo Habkost
0 siblings, 1 reply; 11+ messages in thread
From: Eduardo Otubo @ 2017-09-07 8:38 UTC (permalink / raw)
To: Eduardo Habkost
Cc: Markus Armbruster, mst, qemu-trivial, qemu-devel, Alexander Graf,
qemu-ppc, pbonzini, David Gibson
On Fri, Sep 01, 2017 at 12:44:30PM -0300, Eduardo Habkost wrote:
> On Fri, Sep 01, 2017 at 05:34:34PM +0200, Markus Armbruster wrote:
> > Eduardo Habkost <ehabkost@redhat.com> writes:
> >
> > > i82374 is compiled in only on ppc and sh4, so I'm CCing the
> > > maintainers for those architectures.
> > >
> > > On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:
> > >> When used with the following command line:
> > >>
> > >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
> > >>
> > >> QEMU with machine type 40p already creates the device i82374. If
> > >> specified in the command line, it will try to create it again, hence
> > >> generating the error.
Well pointed, forgot to describe the actual error. I may inlcude for
the next version of the patch. For for correctness sake, here it is:
./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed.
Aborted (core dumped)
> > >
> > > Which error?
> > >
> > >
> > >> One way to avoid this problem is to set
> > >> user_creatable=false.
> > >>
> > >> Signed-off-by: Eduardo Otubo <otubo@redhat.com>
> > >
> > > The patch does more than just avoiding double creation: it
> > > prevents usage of "-device i82374" completely.
> > >
> > > Maybe nobody needs it to work with -device today (would the
> > > device even work?) and it is OK to set user_creatable=false until
> > > we fix the crash. But we need to be sure of that.
> > >
> > >> ---
> > >> hw/dma/i82374.c | 1 +
> > >> 1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
> > >> index 6c0f975df0..5275d822e0 100644
> > >> --- a/hw/dma/i82374.c
> > >> +++ b/hw/dma/i82374.c
> > >> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)
> > >> dc->realize = i82374_realize;
> > >> dc->vmsd = &vmstate_i82374;
> > >> dc->props = i82374_properties;
> > >> + dc->user_creatable = false;
> > >
> > > A "Reason:" comment explaining why user_creatable=false is
> > > mandatory. See the comment above user_creatable declaration in
> > > qdev-core.h for reference.
> > >
> > > I suggest the following:
> > >
> > > /*
> > > * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()
> > > * if the device is instantiated twice.
> > > */
I agree with the comment above. If there's nothing left to fix/add
I'll just send a v2 for this shortly.
> >
> > We need to find out *why* it crashes. Once we know, we can likely write
> > a better comment.
>
> It crashes because isa_bus_dma() isn't supposed to be called
> twice for the same bus.
>
> Making isa_bus_dma()/DMA_init()/i82374_realize() return an error
> instead of asserting would be even better than setting
> user_creatable=false.
>
> --
> Eduardo
>
--
Eduardo Otubo
Senior Software Engineer @ RedHat
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-07 8:38 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
@ 2017-09-09 21:52 ` Eduardo Habkost
0 siblings, 0 replies; 11+ messages in thread
From: Eduardo Habkost @ 2017-09-09 21:52 UTC (permalink / raw)
To: Eduardo Otubo
Cc: Markus Armbruster, mst, qemu-trivial, qemu-devel, Alexander Graf,
qemu-ppc, pbonzini, David Gibson
On Thu, Sep 07, 2017 at 10:38:29AM +0200, Eduardo Otubo wrote:
> On Fri, Sep 01, 2017 at 12:44:30PM -0300, Eduardo Habkost wrote:
> > On Fri, Sep 01, 2017 at 05:34:34PM +0200, Markus Armbruster wrote:
> > > Eduardo Habkost <ehabkost@redhat.com> writes:
> > > > On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:
[...]
> > > >> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
> > > >> index 6c0f975df0..5275d822e0 100644
> > > >> --- a/hw/dma/i82374.c
> > > >> +++ b/hw/dma/i82374.c
> > > >> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)
> > > >> dc->realize = i82374_realize;
> > > >> dc->vmsd = &vmstate_i82374;
> > > >> dc->props = i82374_properties;
> > > >> + dc->user_creatable = false;
> > > >
> > > > A "Reason:" comment explaining why user_creatable=false is
> > > > mandatory. See the comment above user_creatable declaration in
> > > > qdev-core.h for reference.
> > > >
> > > > I suggest the following:
> > > >
> > > > /*
> > > > * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()
> > > > * if the device is instantiated twice.
> > > > */
>
> I agree with the comment above. If there's nothing left to fix/add
> I'll just send a v2 for this shortly.
I suggest amending it with the additional info below, explaining
that isa_bus_dma() isn't supposed to be called twice, and that we
need to make isa_bus_dma()/DMA_init()/i82374_realize() return an
appropriate error if the device is instantiated twice.
>
> > >
> > > We need to find out *why* it crashes. Once we know, we can likely write
> > > a better comment.
> >
> > It crashes because isa_bus_dma() isn't supposed to be called
> > twice for the same bus.
> >
> > Making isa_bus_dma()/DMA_init()/i82374_realize() return an error
> > instead of asserting would be even better than setting
> > user_creatable=false.
> >
> > --
> > Eduardo
> >
>
> --
> Eduardo Otubo
> Senior Software Engineer @ RedHat
--
Eduardo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-01 14:30 ` Eduardo Habkost
2017-09-01 15:34 ` Markus Armbruster
@ 2017-09-02 9:15 ` Aurelien Jarno
2017-09-07 8:38 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
2017-09-07 16:05 ` [Qemu-devel] " Paolo Bonzini
1 sibling, 2 replies; 11+ messages in thread
From: Aurelien Jarno @ 2017-09-02 9:15 UTC (permalink / raw)
To: Eduardo Habkost
Cc: Eduardo Otubo, qemu-devel, qemu-trivial, mst, pbonzini,
David Gibson, Alexander Graf, qemu-ppc
On 2017-09-01 11:30, Eduardo Habkost wrote:
> i82374 is compiled in only on ppc and sh4, so I'm CCing the
> maintainers for those architectures.
The i82374 device is not useful nor usable on SH4. It has just been
added in commit 85d3846a39 to be able to run the tests.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-02 9:15 ` [Qemu-devel] " Aurelien Jarno
@ 2017-09-07 8:38 ` Eduardo Otubo
2017-09-07 16:05 ` [Qemu-devel] " Paolo Bonzini
1 sibling, 0 replies; 11+ messages in thread
From: Eduardo Otubo @ 2017-09-07 8:38 UTC (permalink / raw)
To: Aurelien Jarno
Cc: Eduardo Habkost, mst, qemu-trivial, qemu-devel, Alexander Graf,
qemu-ppc, pbonzini, David Gibson
On Sat, Sep 02, 2017 at 11:15:20AM +0200, Aurelien Jarno wrote:
> On 2017-09-01 11:30, Eduardo Habkost wrote:
> > i82374 is compiled in only on ppc and sh4, so I'm CCing the
> > maintainers for those architectures.
>
> The i82374 device is not useful nor usable on SH4. It has just been
> added in commit 85d3846a39 to be able to run the tests.
>
> Aurelien
>
Any word from the ppc guys?
--
Eduardo Otubo
Senior Software Engineer @ RedHat
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-02 9:15 ` [Qemu-devel] " Aurelien Jarno
2017-09-07 8:38 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
@ 2017-09-07 16:05 ` Paolo Bonzini
2017-09-08 7:57 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
1 sibling, 1 reply; 11+ messages in thread
From: Paolo Bonzini @ 2017-09-07 16:05 UTC (permalink / raw)
To: Jarno, Aurelien
Cc: qemu-devel, Gibson, David, Eduardo Otubo, qemu-trivial, qemu-ppc,
Alexander Graf, mst, Eduardo Habkost
Il 02 set 2017 11:17 AM, "Aurelien Jarno" <aurelien@aurel32.net> ha scritto:
On 2017-09-01 11:30, Eduardo Habkost wrote:
> i82374 is compiled in only on ppc and sh4, so I'm CCing the
> maintainers for those architectures.
The i82374 device is not useful nor usable on SH4. It has just been
added in commit 85d3846a39 to be able to run the tests.
But that means that the patch is wrong and probably was not tested with
"make check".
Eduardo's proposal is the right one.
Paolo
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-07 16:05 ` [Qemu-devel] " Paolo Bonzini
@ 2017-09-08 7:57 ` Eduardo Otubo
0 siblings, 0 replies; 11+ messages in thread
From: Eduardo Otubo @ 2017-09-08 7:57 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Jarno, Aurelien, Eduardo Habkost, mst, qemu-trivial,
Alexander Graf, qemu-devel, qemu-ppc, Gibson, David
On Thu, Sep 07, 2017 at 06:05:37PM +0200, Paolo Bonzini wrote:
> Il 02 set 2017 11:17 AM, "Aurelien Jarno" <aurelien@aurel32.net> ha scritto:
>
> On 2017-09-01 11:30, Eduardo Habkost wrote:
> > i82374 is compiled in only on ppc and sh4, so I'm CCing the
> > maintainers for those architectures.
>
> The i82374 device is not useful nor usable on SH4. It has just been
> added in commit 85d3846a39 to be able to run the tests.
>
>
> But that means that the patch is wrong and probably was not tested with
> "make check".
>
> Eduardo's proposal is the right one.
>
Great, I'll just add the missing details and resend the v2. Thanks for
the review.
Regards,
--
Eduardo Otubo
Senior Software Engineer @ RedHat
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device
@ 2017-09-15 9:06 Eduardo Otubo
2017-09-15 9:26 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
0 siblings, 1 reply; 11+ messages in thread
From: Eduardo Otubo @ 2017-09-15 9:06 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Michael Tokarev, pbonzini, ehabkost,
Markus Armbruster, Alexander Graf
QEMU fails when used with the following command line:
./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed.
Aborted (core dumped)
The 40p machine type already creates the device i82374. If specified in the
command line, it will try to create it again, hence generating the error. The
function isa_bus_dma() isn't supposed to be called twice for the same bus. One
way to avoid this problem is to set user_creatable=false.
A possible fix in a near future would be making
isa_bus_dma()/DMA_init()/i82374_realize() return an error instead of asserting
as well.
Signed-off-by: Eduardo Otubo <otubo@redhat.com>
---
hw/dma/i82374.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
index 6c0f975df0..e76dea8dc7 100644
--- a/hw/dma/i82374.c
+++ b/hw/dma/i82374.c
@@ -139,6 +139,11 @@ static void i82374_class_init(ObjectClass *klass, void *data)
dc->realize = i82374_realize;
dc->vmsd = &vmstate_i82374;
dc->props = i82374_properties;
+ dc->user_creatable = false;
+ /*
+ * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()
+ * if the device is instantiated twice.
+ */
}
static const TypeInfo i82374_info = {
--
2.13.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device
2017-09-15 9:06 [Qemu-devel] " Eduardo Otubo
@ 2017-09-15 9:26 ` Eduardo Otubo
0 siblings, 0 replies; 11+ messages in thread
From: Eduardo Otubo @ 2017-09-15 9:26 UTC (permalink / raw)
To: qemu-devel
Cc: ehabkost, qemu-trivial, Michael Tokarev, Alexander Graf,
Markus Armbruster, pbonzini
(oups, forgot the v2 on Subject)
On Fri, Sep 15, 2017 at 11:06:43AM +0200, Eduardo Otubo wrote:
> QEMU fails when used with the following command line:
>
> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374
> qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed.
> Aborted (core dumped)
>
> The 40p machine type already creates the device i82374. If specified in the
> command line, it will try to create it again, hence generating the error. The
> function isa_bus_dma() isn't supposed to be called twice for the same bus. One
> way to avoid this problem is to set user_creatable=false.
>
> A possible fix in a near future would be making
> isa_bus_dma()/DMA_init()/i82374_realize() return an error instead of asserting
> as well.
>
> Signed-off-by: Eduardo Otubo <otubo@redhat.com>
> ---
> hw/dma/i82374.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
> index 6c0f975df0..e76dea8dc7 100644
> --- a/hw/dma/i82374.c
> +++ b/hw/dma/i82374.c
> @@ -139,6 +139,11 @@ static void i82374_class_init(ObjectClass *klass, void *data)
> dc->realize = i82374_realize;
> dc->vmsd = &vmstate_i82374;
> dc->props = i82374_properties;
> + dc->user_creatable = false;
> + /*
> + * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()
> + * if the device is instantiated twice.
> + */
> }
>
> static const TypeInfo i82374_info = {
> --
> 2.13.5
>
>
--
Eduardo Otubo
Senior Software Engineer @ RedHat
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-09-15 9:26 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-01 11:03 [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device Eduardo Otubo
2017-09-01 14:30 ` Eduardo Habkost
2017-09-01 15:34 ` Markus Armbruster
2017-09-01 15:44 ` Eduardo Habkost
2017-09-07 8:38 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
2017-09-09 21:52 ` Eduardo Habkost
2017-09-02 9:15 ` [Qemu-devel] " Aurelien Jarno
2017-09-07 8:38 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
2017-09-07 16:05 ` [Qemu-devel] " Paolo Bonzini
2017-09-08 7:57 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
-- strict thread matches above, loose matches on Subject: below --
2017-09-15 9:06 [Qemu-devel] " Eduardo Otubo
2017-09-15 9:26 ` [Qemu-devel] [Qemu-trivial] " Eduardo Otubo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).