From: Peter Xu <peterx@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object
Date: Thu, 7 Sep 2017 17:46:08 +0800 [thread overview]
Message-ID: <20170907094608.GC23040@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170907084230.26493-1-famz@redhat.com>
On Thu, Sep 07, 2017 at 04:42:30PM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> configure | 2 +-
> migration/Makefile.objs | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fb7e34a901..470b8a085b 100755
> --- a/configure
> +++ b/configure
> @@ -2818,7 +2818,6 @@ EOF
> rdma_libs="-lrdmacm -libverbs"
> if compile_prog "" "$rdma_libs" ; then
> rdma="yes"
> - libs_softmmu="$libs_softmmu $rdma_libs"
> else
> if test "$rdma" = "yes" ; then
> error_exit \
> @@ -6035,6 +6034,7 @@ echo "CONFIG_TRACE_FILE=$trace_file" >> $config_host_mak
>
> if test "$rdma" = "yes" ; then
> echo "CONFIG_RDMA=y" >> $config_host_mak
> + echo "RDMA_LIBS=$rdma_libs" >> $config_host_mak
> fi
>
> if test "$have_rtnetlink" = "yes" ; then
> diff --git a/migration/Makefile.objs b/migration/Makefile.objs
> index 1c7770da46..99e038024d 100644
> --- a/migration/Makefile.objs
> +++ b/migration/Makefile.objs
> @@ -11,3 +11,4 @@ common-obj-$(CONFIG_RDMA) += rdma.o
>
> common-obj-$(CONFIG_LIVE_BLOCK_MIGRATION) += block.o
>
> +rdma.o-libs := $(RDMA_LIBS)
> --
> 2.13.5
>
--
Peter Xu
next prev parent reply other threads:[~2017-09-07 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 8:42 [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object Fam Zheng
2017-09-07 9:37 ` Dr. David Alan Gilbert
2017-09-07 11:37 ` Fam Zheng
2017-09-07 11:54 ` Dr. David Alan Gilbert
2017-09-07 12:12 ` Daniel P. Berrange
2017-09-07 9:46 ` Peter Xu [this message]
2017-09-07 11:55 ` Juan Quintela
2017-09-08 9:21 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907094608.GC23040@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).