From: Fam Zheng <famz@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>,
Peter Xu <peterx@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object
Date: Thu, 7 Sep 2017 19:37:42 +0800 [thread overview]
Message-ID: <20170907113742.GC25123@lemon.lan> (raw)
In-Reply-To: <20170907093731.GF2098@work-vm>
On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote:
> * Fam Zheng (famz@redhat.com) wrote:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
>
> OK, I've not actually got a preference as to whether it's
> per-object or not - I don't really see any advantage.
Thanks for the review. You're right this probably doesn't make a difference
except for a bit more consistency, until we want to make rdma a module (as in
--enable-modules) like the ones in block layer. The -libs and -cflags variables
were initially added just for that.
While we are talking about it, is there any reason why that will not be a good
idea? There are other libraries used by QEMU outside block layer that are
overdue to be converted to modules, like ui (gtk, sdl, etc.), rdma seems to be a
candidate too.
Fam
next prev parent reply other threads:[~2017-09-07 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 8:42 [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object Fam Zheng
2017-09-07 9:37 ` Dr. David Alan Gilbert
2017-09-07 11:37 ` Fam Zheng [this message]
2017-09-07 11:54 ` Dr. David Alan Gilbert
2017-09-07 12:12 ` Daniel P. Berrange
2017-09-07 9:46 ` Peter Xu
2017-09-07 11:55 ` Juan Quintela
2017-09-08 9:21 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907113742.GC25123@lemon.lan \
--to=famz@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).