From: Cornelia Huck <cohuck@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Add missing -machine accel=qtest
Date: Thu, 7 Sep 2017 11:55:03 +0200 [thread overview]
Message-ID: <20170907115503.4b67c33f.cohuck@redhat.com> (raw)
In-Reply-To: <20170907085310.19353-1-kwolf@redhat.com>
On Thu, 7 Sep 2017 10:53:10 +0200
Kevin Wolf <kwolf@redhat.com> wrote:
> A basic set of qemu options is initialised in ./common:
>
> export QEMU_OPTIONS="-nodefaults -machine accel=qtest"
>
> However, two test cases (172 and 186) overwrite QEMU_OPTIONS and neglect
> to manually set '-machine accel=qtest'. Add the missing option for 172.
> 186 probably only copied the code from 172, it doesn't actually need to
> overwrite QEMU_OPTIONS, so remove that in 186.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/172 | 2 +-
> tests/qemu-iotests/186 | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
I tested this on top of my change switching the default machine to
"tcg:kvm:xen:hax", and this now passes on x86_64 builds both with and
without tcg.
Tested-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2017-09-07 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 8:53 [Qemu-devel] [PATCH] qemu-iotests: Add missing -machine accel=qtest Kevin Wolf
2017-09-07 9:55 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907115503.4b67c33f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).