From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables
Date: Fri, 8 Sep 2017 14:31:06 +0800 [thread overview]
Message-ID: <20170908063106.GF4511@lemon> (raw)
In-Reply-To: <20170906124900.17354-1-famz@redhat.com>
On Wed, 09/06 20:49, Fam Zheng wrote:
> This patch groups the crypto objects into a few .mo objects based on
> functional submodules, and moves inclusion conditions to *-objs
> variables, then moves the global cflags/libs to the *-cflags and *-libs
> variables.
>
> For init.o and cipher.o, which may or may not need the library flags
> depending on config, adding flags and libs unconditionally doesn't hurt,
> because if the library is not available, the variables are empty. This
> makes less code.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Cc Dan. No idea why it was empty.
Fam
next prev parent reply other threads:[~2017-09-08 6:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 12:49 [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables Fam Zheng
2017-09-08 6:31 ` Fam Zheng [this message]
2017-09-08 6:59 ` Fam Zheng
2017-09-08 10:05 ` Daniel P. Berrange
2017-09-08 10:27 ` Fam Zheng
2017-09-08 10:36 ` Daniel P. Berrange
2017-09-08 10:58 ` Fam Zheng
2017-09-08 11:00 ` Daniel P. Berrange
2017-09-08 11:23 ` Fam Zheng
2017-09-08 12:36 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908063106.GF4511@lemon \
--to=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).