From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqCot-0001Ls-11 for qemu-devel@nongnu.org; Fri, 08 Sep 2017 02:31:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqCoo-00035h-3w for qemu-devel@nongnu.org; Fri, 08 Sep 2017 02:31:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58866) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqCon-00035a-Tz for qemu-devel@nongnu.org; Fri, 08 Sep 2017 02:31:10 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFF12883AB for ; Fri, 8 Sep 2017 06:31:08 +0000 (UTC) Date: Fri, 8 Sep 2017 14:31:06 +0800 From: Fam Zheng Message-ID: <20170908063106.GF4511@lemon> References: <20170906124900.17354-1-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906124900.17354-1-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4] buildsys: Move crypto cflags/libs to per object variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, 09/06 20:49, Fam Zheng wrote: > This patch groups the crypto objects into a few .mo objects based on > functional submodules, and moves inclusion conditions to *-objs > variables, then moves the global cflags/libs to the *-cflags and *-libs > variables. > > For init.o and cipher.o, which may or may not need the library flags > depending on config, adding flags and libs unconditionally doesn't hurt, > because if the library is not available, the variables are empty. This > makes less code. > > Signed-off-by: Fam Zheng Cc Dan. No idea why it was empty. Fam