From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drNbL-0001gR-8D for qemu-devel@nongnu.org; Mon, 11 Sep 2017 08:14:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drNbG-0003n6-B1 for qemu-devel@nongnu.org; Mon, 11 Sep 2017 08:14:07 -0400 Date: Mon, 11 Sep 2017 13:13:56 +0100 From: "Daniel P. Berrange" Message-ID: <20170911121356.GN21444@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170911110037.6567-1-lvivier@redhat.com> <20170911110615.GK21444@redhat.com> <20170911134158.1f046176.cohuck@redhat.com> <20170911114347.GL21444@redhat.com> <20170911120441.GB2857@work-vm> <616d2319-1198-5a20-ebf4-ac2c532352db@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <616d2319-1198-5a20-ebf4-ac2c532352db@redhat.com> Subject: Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: "Dr. David Alan Gilbert" , Cornelia Huck , Thomas Huth , David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Mon, Sep 11, 2017 at 02:10:14PM +0200, Laurent Vivier wrote: > On 11/09/2017 14:04, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berrange@redhat.com) wrote: > >> On Mon, Sep 11, 2017 at 01:41:58PM +0200, Cornelia Huck wrote: > >>> On Mon, 11 Sep 2017 12:06:15 +0100 > >>> "Daniel P. Berrange" wrote: > >>> > >>>> On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote: > >>>>> Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) > >>>>> fixes the problem for i386, do the same for ppc. > >>>> > >>>> What about all the other targets QEMU supports ? Have you checked if they > >>>> are similarly affected, as we don't want to wait another 6 months to get a > >>>> bug report that s390 or aarch64 crash in exactly the same way too. > >>> > >>> This patch actually prompted me to check s390, and the mentioned > >>> command line works fine. > >>> > >>> However, if we start a qemu with no guest memory defined and then call > >>> dump-guest-memory without filtering, we get a core dump instead of a > >>> guest dump (s390x or x86_64, machine none). > >>> > >>> I can take a stab at fixing that, unless someone beats me to it. > >> > >> I wonder if someone wants to write a qtest job to run dump-guest-memory > >> across all machine types, on all targets. Seems we have enough crashiness > >> in this code to make it worthwhile to test > > > > We do have - that's how we found this case; it's part of test-hmp. > > The test-hmp runs by default with 0 MB of memory, the problem can only > be found with some memory added to the machine. > > Perhaps we can simply update the test to add memory? Probably best to run it twice, 0MB and with say 2MB, as they're both fairly magic values. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|