From: Kevin Wolf <kwolf@redhat.com>
To: "WangJie (Captain)" <wangjie88@huawei.com>
Cc: berto@igalia.com, stefanha@redhat.com, famz@redhat.com,
qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] question： I found a bug which will lead to qemu crash
Date: Tue, 12 Sep 2017 13:37:22 +0200 [thread overview]
Message-ID: <20170912113722.GH29136@localhost.localdomain> (raw)
In-Reply-To: <59B7C252.1070004@huawei.com>
Am 12.09.2017 um 13:17 hat WangJie (Captain) geschrieben:
> Hi, Kevin.
>
> I found a bug about qemu-kvm(version 2.7.0-rc0 adn 2.8.1). but qemu 2.6.0 and current master is OK.
> So I git-bisect the master branch，and I found the patch you commited (block: Decouple throttling from BlockDriverState) lead the bug into qemu.
>
> The patch which lead the bug into qemu: (https://github.com/qemu/qemu/commit/7ca7f0f6db1fedd28d490795d778cf23979a2aa7#diff-ea36ba0f79150cc299732696a069caba)
>
> Because the current master is OK. So I think you had fixed it , can you tell me which patch fixed the bug? Thank you :>
I can't tell offhand which fix this was, but you can use 'git bisect'
not only to find which commit introduced the bug, but also to find the
fix. You just bisect between a broken commit and master, and then use
the reversed meaning of 'good' and 'bad' (i.e. 'good' means that the bug
is still there, 'bad' means it is already fixed).
Kevin
next prev parent reply other threads:[~2017-09-12 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 11:17 [Qemu-devel] question： I found a bug which will lead to qemu crash WangJie (Captain)
2017-09-12 11:37 ` Kevin Wolf [this message]
2017-09-12 13:53 ` Eric Blake
2017-09-12 12:00 ` Alberto Garcia
2017-09-12 13:37 ` WangJie (Captain)
2017-09-12 13:51 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912113722.GH29136@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangjie88@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).